620531 - [Classic] Missing Treelines in bookmarks (sidebar and manager)

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Karsten Düsterloh]

Yet again... :-(

+++ This bug was initially created as a regression clone of Bug #438793 +++

Trees with at least 2 sub levels should have tree lines, as was done in bug 438793. This regressed for bookmarks, probably when porting from toolkit.

Comment 1

[[e-mail]]

That would have been KaiRo's fault then ;-)

Comment 2

[Karsten Düsterloh]

Attachment: add missing treelines attribute

I also took the liberty to fix the stray multi-attribute line.

Comment 3

[[e-mail]]

Comment on attachment 499016 [details] [diff] [review]
add missing treelines attribute

I noticed that editBookmarkOverlay.xul (used for editing a bookmark either for the current page via the star button), when you select the full folder chooser, already has treelines enabled. But you seem to have overlooked the bookmarks manager's Edit - Move bookmark dialog for some reason.

Comment 4

[Karsten Düsterloh]

Attachment: also fix moveBookmarks.xul

(In reply to comment #3)
> But you seem to have overlooked the bookmarks manager's Edit - Move bookmark
> dialog for some reason.

Man, that dialog is so 90's UI... :-/

Taking over r/sr.

Landed as <http://hg.mozilla.org/comm-central/rev/d9239f961031>.