620870 - No success message on saving changes

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

[from the etherpad]

No success message on saving. We should use new (collections) notification styles for this.

Comment 1

[krupa raj[:krupa]]

https://github.com/jbalogh/zamboni/commit/54d8ae789

Comment 2

[krupa raj[:krupa]]

No success message on changing values on:

* edit page
* manage versions page
* dev-profile page

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> No success message on changing values on:
> * edit page

chowse: This is the ajax-edit page.  Should there be any message? Where would it go?

Comment 4

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> No success message on changing values on:
> * manage versions page
> * dev-profile page

http://github.com/jbalogh/zamboni/commit/9eef9c1

cc'ing chowse for comment 3.

Comment 5

[Chris Howse [:chowse]]

On save, I'd add a badge that appears beside the header for 2 secs, fades out in 1 sec, then is removed. Here's some style for the badge:

.save-badge {
    background: #41B300;
    border-radius: 1em;
    color: #fff;
    font-family: helvetica, arial, sans-serif;
    font-size: 10px;
    font-style: normal;
    font-weight: bold;
    margin-left: 0.5em;
    padding: 0.375em 1em;
}

Comment 6

[Chris Howse [:chowse]]

Attachment: Screenshot of Save Badge

Comment 7

[Jeff Balogh (:jbalogh)]

edit page: http://github.com/jbalogh/zamboni/commit/d6f5745

Thanks chowse!

Comment 8

[krupa raj[:krupa]]

verified  that there are success  messages on change @

* edit page
* manage versions page
* dev-profile page