620896 - Popup notification button size is off when DirectWrite is disabled

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Maciej Adamczak]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20101221 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20101221 Firefox/4.0b9pre

Split button wrong size with d2d disable:
http://img257.imageshack.us/img257/4269/withoutdirect2d.png
And enabled:
http://img821.imageshack.us/img821/530/withdirect2d.png
(also notice different sizes of browser UI elements)

Reproducible: Always

Steps to Reproduce:
1. Enter about:config
2. Switch gfx.direct2d.disabled setting.
3. Restart browser.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 500657 [details] [diff] [review]
patch

This looks reasonable for Windows Classic and Linux, which is all I can test.

>   .popup-notification-menubutton > .button-menubutton-button {
>-%ifdef WINSTRIPE_AERO
>-    padding: 0;
>-%else
>-    padding: 2px 0;
>-%endif
>+    padding-top: 0;
>+    padding-bottom: 0;
[Possibly this can go, since I can't seem to find any existing padding.]

Comment 3

[Dão Gottwald [:dao]]

> >   .popup-notification-menubutton > .button-menubutton-button {
> >-%ifdef WINSTRIPE_AERO
> >-    padding: 0;
> >-%else
> >-    padding: 2px 0;
> >-%endif
> >+    padding-top: 0;
> >+    padding-bottom: 0;
> [Possibly this can go, since I can't seem to find any existing padding.]

true!

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/c64b948c1b9c