Closed
Bug 621004
Opened 14 years ago
Closed 13 years ago
AIX(,HPUX): jsval.h JSVAL_ALIGNMENT definition for AIX / skip C++ enum usage
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: andrew, Assigned: andrew)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 2 obsolete files)
1.05 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
The IBM XL C/C++ compile supports __attribute__((aligned (8))) just like gcc.
Attachment #499333 -
Flags: review?(mrbkap)
Assignee | ||
Comment 1•14 years ago
|
||
Hmm.. modifying patch to also skip the enum typedef in C++ mode because xlC does not support unsigned integer enum constants.
Summary: AIX: jsval.h JSVAL_ALIGNMENT definition for AIX → AIX: jsval.h JSVAL_ALIGNMENT definition for AIX / skip C++ enum usage
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #499333 -
Attachment is obsolete: true
Attachment #499335 -
Flags: review?(mrbkap)
Attachment #499333 -
Flags: review?(mrbkap)
Assignee | ||
Updated•14 years ago
|
Attachment #499335 -
Flags: approval2.0?
Assignee | ||
Comment 3•13 years ago
|
||
Added HP cc/aCC which also need to blank out JSVAL_ALIGNMENT.
Attachment #499335 -
Attachment is obsolete: true
Attachment #499558 -
Flags: review?(mrbkap)
Attachment #499558 -
Flags: approval2.0?
Attachment #499335 -
Flags: review?(mrbkap)
Attachment #499335 -
Flags: approval2.0?
Assignee | ||
Updated•13 years ago
|
Summary: AIX: jsval.h JSVAL_ALIGNMENT definition for AIX / skip C++ enum usage → AIX(,HPUX): jsval.h JSVAL_ALIGNMENT definition for AIX / skip C++ enum usage
Comment 4•13 years ago
|
||
Comment on attachment 499558 [details] [diff] [review] Define JSVAL_ALIGNMENT and skip enum type definition r+ before a?, please (we'll probably take these after we ship)
Attachment #499558 -
Flags: approval2.0?
Updated•13 years ago
|
Attachment #499558 -
Flags: review?(mrbkap) → review+
Updated•13 years ago
|
Assignee: general → andrew
Comment 5•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/e8dda9a82da7
Whiteboard: fixed-in-tracemonkey
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e8dda9a82da7
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•