Closed
Bug 621136
Opened 14 years ago
Closed 14 years ago
Lightning 32/64 bit universal builds broken due to not referencing the correct location for components
Categories
(Calendar :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b4
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
1.85 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Currently the universal builds for Mac are packaged with binary components like this: platform/Darwin_x86-gcc3/components/libcalbasecomps.dylib platform/Darwin_x86_64-gcc3/components/libcalbasecomps.dylib The components.manifest just references the component: binary-components libcalbasecomps.dylib This is no longer valid as with the new manifest system it doesn't go searching per-platform. Given the new method, my proposal is to locate them like this: components/Darwin_x86-gcc3/libcalbasecomps.dylib components/Darwin_x86_64-gcc3/libcalbasecomps.dylib and use a components.manifest like this: binary-component Darwin_x86-gcc3/libcalbasecomps.dylib ABI=Darwin_x86-gcc3 binary-component Darwin_x86_64-gcc3/libcalbasecomps.dylib ABI=Darwin_x86_64-gcc3 This both simplifies the layout and restores the functionality. I'm attaching a patch that will do this, with that patch Lightning works for me on trunk Thunderbird. There are try server builds being generated and will be available here in a few hours: http://ftp.mozilla.org/pub/mozilla.org/thunderbird/tryserver-builds/bugzilla@standard8.plus.com-5714757c154d I don't mind who wants to review it. I'll land when I get review and we can always follow-up.
Attachment #499495 -
Flags: review?(philipp)
Attachment #499495 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 1•14 years ago
|
||
Ok, so the try server builds are up. Not everything works in Lightning, but at least you can view the current month.
Comment 2•14 years ago
|
||
Comment on attachment 499495 [details] [diff] [review] The fix Thanks for taking care, r=philipp
Attachment #499495 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/51ba0686c49c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0b3
Assignee | ||
Updated•14 years ago
|
Attachment #499495 -
Flags: review?(bugspam.Callek)
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite-
Updated•14 years ago
|
Target Milestone: 1.0b3 → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•