621737 - Infinite redirect loop if user profile doesn't exist

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P2)

Description

[James Socol [:jsocol, :james]]

If a user doesn't exist, going to their profile at /users/123456/ will raise a 404, that our strip-slash middleware will catch, and redirect to /users/123456. Since that's not a valid route, Django will add the slash and send it back to /users/123456/, which, etc...

We should steal AMO's method of dealing with trailing slashes, as it avoids this.

Also, we should get consistent, and either use them everywhere or nowhere, but that's a bigger bug.

This is not a Users & Groups bug, because the slash-stripping middleware is global. This is just an easy example/test-case.

Comment 1

[Paul Craciunoiu [:paulc]]

URLs don't have slashes anymore. URLs with slashes are redirected to the removed-trailing-slash version.

https://github.com/jsocol/kitsune/commit/b2bc6de1f6d6c33ba497f9326394dab9d4bff73d

Comment 2

[Rebecca Billings [:rbillings]]

Verified going to invalid user profile with or without trailing slash just gets page not found- no error or redirect