623069 - GCHiddenPointer doesn't need to hide its copy ctor

Status: VERIFIED WONTFIX

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Steven Johnson]

Just what it says -- it does so presumably out of copy-n-paste from other smart-pointerish classes, but there's no justification for it, and blocking it prevents a use in Flash that will be handy. (Yes, GCHiddenPointer is kinda evil and deprecated, but until it's actually slated for demolition, we might as well make it convenient.)

Comment 1

[Steven Johnson]

Attachment: Patch

The magic of "explicit" is probably what we wanted (to avoid temporaries being created)...

Comment 2

[Lars T Hansen]

(In reply to comment #0)
> (Yes, GCHiddenPointer is kinda evil
> and deprecated, but until it's actually slated for demolition, we might as well
> make it convenient.)

That doesn't make sense: if it's evil and deprecated then making it convenient can only make it harder to remove it later.

Comment 3

[Tommy Reilly]

Comment on attachment 501188 [details] [diff] [review]
Patch

Seems fine although if we're touching player code that's using GCHiddenPointer we should think about removing it or at least creating a player bug with thoughts on how it could be done.

Comment 4

[Steven Johnson]

(In reply to comment #2)
> That doesn't make sense: if it's evil and deprecated then making it convenient
> can only make it harder to remove it later.

Er. Yeah. Guilty as charged.

Comment 5

[Lars T Hansen]

Comment on attachment 501188 [details] [diff] [review]
Patch

Holding my nose, SR+.

Comment 6

[Tommy Reilly]

Even though I accepted this I bonged Steven's player change that used this so this bug should be closed now I think?

Comment 7

[Trevor Baker]

bulk verifying resolved !fixed issues