623589 - Remove aCanBePercent parameter from nsAttrValue::ParseSpecialIntValue

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

All callers pass true.

Comment 1

[Peter Van der Beken [:peterv]]

Comment on attachment 501650 [details] [diff] [review]
Patch v1

>diff --git a/content/html/content/src/nsGenericHTMLElement.cpp b/content/html/content/src/nsGenericHTMLElement.cpp

>-                                          const nsAString& aString,
>+                                          const nsAString& aValue,

Please undo this, it's unrelated to the main change and it muddies the blame.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 501650 [details] [diff] [review]
Patch v1

(In reply to comment #1)
> Comment on attachment 501650 [details] [diff] [review]
> Patch v1
> 
> >diff --git a/content/html/content/src/nsGenericHTMLElement.cpp b/content/html/content/src/nsGenericHTMLElement.cpp
> 
> >-                                          const nsAString& aString,
> >+                                          const nsAString& aValue,
> 
> Please undo this, it's unrelated to the main change and it muddies the blame.

Will do.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Thanks!

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/beb7483fcb5d

Comment 5

[(no longer active)]

I backed this patch as part of this pushlog <http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=7e12e3e16e6c> because of the oranges it caused <http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1296852850.1296854923.2345.gz&fulltext=1>.

I'm not sure which one of the bugs was at fault, so I just backed them all out.  The assignee needs to investigate and make sure that his patch has not been the culprit, and then re-add checkin-needed.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Relanded all but one of the patches in that push.  For this bug, that's:
http://hg.mozilla.org/mozilla-central/rev/a65173888809