623985 - Line break on the "free download" button

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: screenshot (showing bug)

See screenshot.

Looks to be a font issue. dholbert says it looks fine for him, but he has the ubuntu-restricted-extras package installed, which includes Microsoft fonts (including apparently Georgia).

So we should add a better fallback font and/or but   to at the very least keep "free download" from splitting.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot (no bug)

Here's a screenshot of what I see.  The font for at least "3.6" is noticeably different from zpao's screenshot (my "3" dips below the baseline whereas zpao's does not), so it's almost certainly a font difference between my computer & zpao's. (likely from ubuntu-restricted-extras, as zpao noted)

Comment 2

[Bill Gianopoulos [:WG9s]]

I did some more looking into this and the issue is that for that it the use of font family Georgia with a fallback of serif and a font size of 22px.  It is the combination of using 22px and a generic serif in combination as a fallback that is causing the issue.  It would be better to use a font size that is more universally supported in serif fonts (like 24px).

For what it is worth, I fixed this problem for me under Firefox 4.0b8pre with the release STIX 1.0 fonts installed by modifying my Firefox default serif font to be "STIX General".

Comment 3

[Bill Gianopoulos [:WG9s]]

To clarify what I was trying to say above a bit.  If you actually have Georgia (which is the preferred) font installed it supports a 22px size so everything fits.  The problem is that if you do not and it falls back to the system default serif font, that is likely to only support "normal" font sizes of which 22px is not one so it will probably end up using 24px instead, which results in making the "Firefox 3.6" part wide enough so that the "free download" part does not fit without wrapping.

I, therefore, would suggest redoing the layout to specify and display properly with a font size of 24px.

An even better solution would be to specify that the entire string not wrap and auto size the width of the green bar depending on the text width.

Comment 4

[Bill Gianopoulos [:WG9s]]

(In reply to comment #2)
> For what it is worth, I fixed this problem for me under Firefox 4.0b8pre with
> the release STIX 1.0 fonts installed by modifying my Firefox default serif font
> to be "STIX General".

I was able to achieve the same results by specifying the more universally available under Linux "Century Schoolbook L" font as the default Firefox serif font.

Comment 5

[John Slater]

Steven, can you help here?

Comment 7

[Steven Garrity [:sgarrity]]

(In reply to comment #5)
> Steven, can you help here?

Yup - It looks like this is happening when the Georgia font isn't available (often the case on linux). Will fix.

Comment 8

[Steven Garrity [:sgarrity]]

Fixed in trunk in r80556. Merged to stage in r80581. QA should be sure to include IE6 in testing, as that browser is specifically targeted with some side-effects on this fix.

Comment 9

[raymond [:retornam] (inactive)]

problem still exists on http://www-trunk.stage.mozilla.com/en-US/about/ using Firefox 3.6 on Ubuntu.

Comment 10

[Steven Garrity [:sgarrity]]

Re-fixed in trunk in r80594. Re-merged to stage in r80595.

Comment 11

[raymond [:retornam] (inactive)]

qa-verified-trunk  http://www-trunk.stage.mozilla.com/en-US/about/

Comment 12

[Daniel Holbert [:dholbert]]

FWIW, I filed  Bug 626730 for a similar issue on /firefox/ instead of /about/.

Comment 13

[James Long (:jlongster)]

pushed to production
r81589 | [e-mail] | 2011-01-25 14:48:17 -0500 (Tue, 25 Jan 2011) | 8 lines

Comment 14

[raymond [:retornam] (inactive)]

verified fixed http://www.mozilla.com/en-US/about/