624101 - Make our canvases be moz-opaque

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

According to this page [1] canvas in Mozilla can have the dom attribute "dom-opaque"="true" (bug 430906) and this could speed up their rendering.

[1] https://developer.mozilla.org/En/Firefox_3.5_for_developers

Since, I believe all our tab canvases are always opaque, we should be slapping this on all our canvases.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #0)
> According to this page [1] canvas in Mozilla can have the dom attribute
> "dom-opaque"="true" (bug 430906) and this could speed up their rendering.

Whoops! Make that "moz-opaque".

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Do we need a test for this?

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 503289 [details] [diff] [review]
patch v1

Looks good to me, bug I'd also like to hear from roc, for verification that this is a good idea.

No test needed.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Someone approve this! It's an easy win.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/653ad2c5782e

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Should've been moz-opaque='', though.

Comment 9

[Ian Gilman [:iangilman]]

(In reply to comment #8)
> Should've been moz-opaque='', though.

Why so? 'true' seems to be working.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to comment #9)
> (In reply to comment #8)
> > Should've been moz-opaque='', though.
> 
> Why so? 'true' seems to be working.

Right, and when someone wants to revert this, they'll use moz-opaque='false' and have a hard time finding out why that doesn't change anything. See <http://www.whatwg.org/html/#boolean-attributes>.

Comment 11

[Brendan Eich [:brendan]]

Agree with Ms2ger on ='true' being bug-bait. But shorter's better, so why not use just moz-opaque (no ='' or =anything)?

/be

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2, followup

Comment 13

[Ian Gilman [:iangilman]]

Comment on attachment 505399 [details] [diff] [review]
patch v2, followup

(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Should've been moz-opaque='', though.
> > 
> > Why so? 'true' seems to be working.
> 
> Right, and when someone wants to revert this, they'll use moz-opaque='false'
> and have a hard time finding out why that doesn't change anything. See
> <http://www.whatwg.org/html/#boolean-attributes>.

I see! Thanks for setting us straight!

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 15

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/32738fd1cdfb