Closed
Bug 624151
Opened 13 years ago
Closed 13 years ago
Better positioning for the invalid form popup
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b10
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
1.63 KB,
patch
|
enndeakin
:
review+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
This was originally part of bug 619223 but split to make things easier. We should prevent this situation: http://fredericiana.com/wp-content/uploads/2010/12/html5-feedback-forms-1.jpg
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #502257 -
Flags: review?(enndeakin)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs-review]
Comment 2•13 years ago
|
||
Comment on attachment 502257 [details] [diff] [review] Patch v1 >+ let style = element.ownerDocument.defaultView.getComputedStyle(element, null); This should be inside the else block. >+ } else { >+ offset = parseInt(style.paddingLeft) + parseInt(style.borderLeftWidth); >+ position = "after_start"; >+ } Do you need to use the right padding and border for rtl? Unfortunately, it doesn't look like paddingStart/borderStartWidth is implemented for getComputedStyle.
Attachment #502257 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to comment #2) > Comment on attachment 502257 [details] [diff] [review] > Patch v1 > > >+ let style = element.ownerDocument.defaultView.getComputedStyle(element, null); > > This should be inside the else block. > > >+ } else { > >+ offset = parseInt(style.paddingLeft) + parseInt(style.borderLeftWidth); > >+ position = "after_start"; > >+ } > > Do you need to use the right padding and border for rtl? Unfortunately, it > doesn't look like paddingStart/borderStartWidth is implemented for > getComputedStyle. Indeed, I should change that.
Assignee | ||
Updated•13 years ago
|
Attachment #502257 -
Flags: approval2.0?
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs-review] → [needs-approval]
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs-approval] → [needs approval][passed try]
Comment 4•13 years ago
|
||
Comment on attachment 502257 [details] [diff] [review] Patch v1 a=beltzner
Attachment #502257 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 5•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/d910f58e6c9c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs approval][passed try]
Target Milestone: --- → Firefox 4.0b10
You need to log in
before you can comment on or make changes to this bug.
Description
•