Closed
Bug 625126
Opened 14 years ago
Closed 14 years ago
Make logHelper's mark_failure work a little better
Categories
(MailNews Core :: Testing Infrastructure, defect)
MailNews Core
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a2
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file)
|
2.93 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
(Yes, I'm bundling several fixes in one, but this is whatever I had to fix to get error messages in bug 624108 working properly. Plus they're all kind of related, so I'm not apologizing :) ) Three fixes: 1. Make _normalize_for_json recognize HTML elements. 2. For objects that aren't recognized, return an object instead of a string. Bad things happen when strings are tested with the in operator, as happens in mark_failure. 3. Use the JSON output in mark_failure to generate text rather than the implicit call to obj.toString().
Attachment #503234 -
Flags: review?(bugmail)
|
||
Updated•14 years ago
|
Attachment #503234 -
Flags: review?(bugmail) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
https://hg.mozilla.org/comm-central/rev/3ac5765940a6
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in
before you can comment on or make changes to this bug.
Description
•