Closed
Bug 625242
Opened 14 years ago
Closed 13 years ago
cef logging not generally taking a username
Categories
(Cloud Services :: Server: Core, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: telliott, Assigned: telliott)
References
Details
Attachments
(4 files, 2 obsolete files)
1.13 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
6.71 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
6.64 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
2.95 KB,
patch
|
tarek
:
review+
|
Details | Diff | Splinter Review |
I noticed while reviewing some other code that the usual line for cef logging doesn't take a username. Ignoring the fact that we should probably have that be a normal parameter (since 90% of the time we'll want it), there are several places in the python that probably need to add {'suser': username} to the **params
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → tarek
Comment 1•14 years ago
|
||
Let's make it a normal parameter then, defaulting to None.
Comment 2•14 years ago
|
||
Attachment #504480 -
Flags: review?(telliott)
Assignee | ||
Comment 3•14 years ago
|
||
should we put username in front of signature? I'm far more likely to put in a username than a signature.
Comment 4•13 years ago
|
||
Yeah sure. Also, maybe we should rename it to log_cef() now that it's used in other spots than log failures. It will be more painful to do so once we have more apps.
Assignee | ||
Comment 5•13 years ago
|
||
Sure, that seems fine. We could even leave in the log_failure function as a pointer to log_cef for a bit to ensure nothing breaks.
Comment 6•13 years ago
|
||
Since nothing using server-core is in production yet, I think having a deprecation process for that name is unnecessary: we can rename it everywhere with no impact but the need to update it in all stage environment -- and gives a heads-up to JR about this.
Comment 7•13 years ago
|
||
Revised version
Attachment #504480 -
Attachment is obsolete: true
Attachment #505372 -
Flags: review?(telliott)
Attachment #504480 -
Flags: review?(telliott)
Comment 8•13 years ago
|
||
Attachment #505374 -
Flags: review?(telliott)
Comment 9•13 years ago
|
||
Attachment #505379 -
Flags: review?(telliott)
Assignee | ||
Updated•13 years ago
|
Attachment #505374 -
Flags: review?(telliott) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #505379 -
Flags: review?(telliott) → review+
Comment 10•13 years ago
|
||
Attachment #505372 -
Attachment is obsolete: true
Attachment #506333 -
Flags: review?(telliott)
Attachment #505372 -
Flags: review?(telliott)
Assignee | ||
Comment 11•13 years ago
|
||
Comment on attachment 506333 [details] [diff] [review] Added the suser value and renamed the function Looks good. I'll attach the account portal changes here, too
Attachment #506333 -
Flags: review?(telliott) → review+
Assignee | ||
Comment 12•13 years ago
|
||
Attachment #506485 -
Flags: review?(tarek)
Updated•13 years ago
|
Attachment #506485 -
Flags: review?(tarek) → review+
Comment 13•13 years ago
|
||
Done for me in : - http://hg.mozilla.org/services/server-core/rev/230271073c16 - http://hg.mozilla.org/services/server-reg/rev/220a94044d9f
Updated•13 years ago
|
Assignee: tarek → telliott
Assignee | ||
Comment 14•13 years ago
|
||
Done on account-portal in http://hg.mozilla.org/services/account-portal/rev/1a2b8dfb04a6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 15•13 years ago
|
||
And in: http://hg.mozilla.org/services/server-key-exchange/rev/7420be65dc70
You need to log in
before you can comment on or make changes to this bug.
Description
•