Closed
Bug 625377
Opened 13 years ago
Closed 13 years ago
JM: incorrect output for testcase involving for..in, delete
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: jandem, Assigned: dvander)
References
Details
(Keywords: regression, testcase, Whiteboard: [hardblocker][fixed-in-tracemonkey])
Attachments
(2 files)
287 bytes,
application/x-javascript
|
Details | |
12.14 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
The attached testcase should print: onetwo onetwo onetwo ./js -m (32-bit OS X): onetwo onetwoundefined onetwoundefined Uncommenting the gc() call fixes it. Seems related to bug 618614.
Reporter | ||
Updated•13 years ago
|
blocking2.0: --- → ?
Keywords: regression,
testcase
Reporter | ||
Comment 1•13 years ago
|
||
Here's a simpler testcase: --- for(var i=0; i<3; i++) { var obj = { first: "first", second: "second" }; var count = 0; for (var elem in obj) { delete obj.second; count++; } print(count); } --- This should print: 1 1 1 Output with -m (32-bit OS X): 1 2 2
Assignee | ||
Updated•13 years ago
|
Assignee: general → dvander
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•13 years ago
|
||
Easy bug. The method JIT is not updating ni->obj so property deletion suppression doesn't fix up the iterator. We had a similar bug for the interpreter.
blocking2.0: ? → final+
Assignee | ||
Comment 3•13 years ago
|
||
This patch also cleans up some really old code and assumptions (like, assuming that iterators won't work on X64 - 3% SunSpider win).
Attachment #503553 -
Flags: review?(lw)
Updated•13 years ago
|
Whiteboard: hardblocker
Comment 4•13 years ago
|
||
Comment on attachment 503553 [details] [diff] [review] fix Nice
Attachment #503553 -
Flags: review?(lw) → review+
Comment 5•13 years ago
|
||
Whew! Nice ifdef reduction. /be
Assignee | ||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/7b3e7428113c
Whiteboard: hardblocker → [hardblocker][fixed-in-tracemonkey]
Reporter | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7b3e7428113c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•