625476 - About Dialog should not use vendorShortName in the global community statement.

Status: NEW

(Firefox :: General, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Netscape Navigator Rebrand

See attached screen shot.

In the context of this sentence:

"Firefox is designed by Mozilla, a global community working together to make the Internet better."

It doesn't make sense to replace Firefox and/or Mozilla with their brandShortName and vendorShortName equivalents from branding.

See attached screenshot to understand why.

The sentence should read the same, regardless of the branding.

Incidentally, where does this statement come from? I couldn't find it in the source code.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The string's in aboutDialog.dtd, we should just move it to the branding package, I suppose.

Comment 2

[Mike Kaply [:mkaply]]

Flod, Can I get your opinion on this old bug? :)

I'm tempted to do a patch.

Comment 3

[Francesco Lodolo [:flod]]

Since comment 1 mentions branding package, could you clarify what the fix would be?

If the idea is to replicate what trademarkInfo does, then I guess it would be OK: move the existing string in official/brand.ftl, keep the string empty in all other channels. Putting an actual string in nightly and aurora wouldn't work, because it would remain in English for all versions other than release (that's the only brand exposed for localization).

If you're thinking of hard-coding Firefox and Mozilla there, and display it for any version, that would work for me and there's no need to move the string from aboutDialog.ftl (we just need a better ID than community-2).

Comment 4

[Mike Kaply [:mkaply]]

Yeah, fix would be to hardcode them. That sentence really requires Mozilla and Firefox, it's not about the brand or vendor, so if someone took Firefox and rebranded, we would still want that sentence to say "Firefox" and "Mozilla"

Comment 5

[Francesco Lodolo [:flod]]

It works for me, but note that there are two versions of that blurb at this point, one of Nightly and one for official versions
https://searchfox.org/mozilla-central/rev/a26af613a476fafe6c3eba05a81bef63dff3c9f1/browser/base/content/aboutDialog.js#65