625676 - Disable Close and TaskSwitcher buttons on Maemo6

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Disable home, taskswitcher buttons on maemo6

On maemo6 we don't need close and taskswitcher buttons, similar to Android.

Here is the simple patch to disable it

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 503772 [details] [diff] [review]
Disable home, taskswitcher buttons on maemo6

># HG changeset patch
># Parent b2d7a9386babc231f42313199c66f09d539dd70e
>diff --git a/chrome/content/browser.xul b/chrome/content/browser.xul
>--- a/chrome/content/browser.xul
>+++ b/chrome/content/browser.xul
>@@ -212,17 +212,17 @@
>       <!-- Page Area -->
>       <stack class="window-width window-height">
>         <scrollbox id="page-scrollbox" class="window-width window-height">
>           <vbox>
>             <!-- Main Toolbar -->
>             <box id="toolbar-container" class="panel-dark toolbar-height">
>               <box id="toolbar-moveable-container">
>                 <toolbar id="toolbar-main" class="panel-dark window-width">
>-#ifdef MOZ_PLATFORM_MAEMO
>+#if MOZ_PLATFORM_MAEMO != 6

This would trigger for Android, right? You'll need to keep the outer #ifdef MOZ_PLATFORM_MAEMO

>                     </hbox>
>                   </hbox>
> #ifndef ANDROID
>+#if MOZ_PLATFORM_MAEMO != 6
>                   <toolbarbutton id="tool-app-close" class="urlbar-button" command="cmd_close"/>
> #endif
>+#endif

This one should be OK I think

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Updated patch

Comment 3

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mobile-browser/rev/6ad3f7c8ab25