625677 - validator links are 404

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Justin Scott [:fligtar]]

the devhub navigation in both remora and zamboni under Tools -> Add-on Validator sends to 404

https://addons.mozilla.org/en-US/developers/addon/validate

Comment 1

[Potch [:potch]]

That url is really unfortunate with the new slugs scheme- It looks like we now think you're editing an addon called "validate". I don't know what we can do with rewrite rules to patch around that, if at all.

Comment 2

[Justin Scott [:fligtar]]

couldn't a [L] rule specific to validate supersede slugs?

Comment 3

[Kumar McMillan [:kumar]]

I'm not sure about Remora but in Zamboni this page doesn't even exist. D'oh.  All we have is 1) the ability to upload/validate a new Add-on or 2) go to the versions page and click "validate now" for any unvalidated files.

Does it still make sense in Zamboni to have a separate validator page completely detached from the Add-on submission process?

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #3) 
> Does it still make sense in Zamboni to have a separate validator page
> completely detached from the Add-on submission process?

Yes.

Comment 5

[Justin Scott [:fligtar]]

Yes, but we don't need to do that as part of this bug. I was aware we didn't and noted in flignotes. For now we can still link to the Remora validator page and when we rewrite the rest of the Developer Hub we'll get it too.

Comment 6

[Andy McKay]

We should stop an addon from getting the slug validate as well.

Comment 7

[Wil Clouser [:clouserw]]

This is fixed on PAMO.  We had to hardcode the URL in a rewrite.  I made sure it still validated and made sure the new dev tools worked, but we should get some more eyes on it before we push it live.  Just poke around and make sure stuff still works.

RewriteRule ^(?:(?:/\w{2,3}(?:-\w{2})?)?(?:/(?:firefox|seamonkey|thunderbird|mobile|sunbird))?)?/developers/addon/validate(?:/.*)?$ - [L]

Is what we used I think

Comment 8

[Kumar McMillan [:kumar]]

(In reply to comment #6)
> We should stop an addon from getting the slug validate as well.

Hmm, a lot of URLs in devhub would have to be re-written if we were to support slugs on developer pages.  The devhub urls.py still only supports addon IDs.

Comment 9

[Kumar McMillan [:kumar]]

I moved the devhub/slug issue to bug 625842 -- Sorry if there's a dupe, I searched but couldn't find it.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on preview.