62572 - remove obsolete/bogus ns*ID* check

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Michael Ang]

There currently exists code in xpidl_typelib that tries to let you declare nsID
and related types without flagging them with [nsid].  E.g. "native nsID(nsID);"
instead of "[nsid] native nsID(nsID);".  I guess this was needed at some point,
but it shouldn't be needed now.

In fact, this code is never executed for the most common case (possibly
other/all cases), since |verify_method_declaration| acts as a gate and isn't as
loose.

Comment 1

[Michael Ang]

Attachment: Patch to xpidl_typelib removing dead code

Comment 2

[Michael Ang]

I rebuilt all .h/.xpt files on Linux and didn't find any places relying on the
old behaviour.

mccabe/jband - Can I pls get r/sr to check it in?

Comment 3

[John Bandhauer]

sr=jband. Yes, please!

Comment 4

[Mike McCabe]

r=mccabe!

Comment 5

[Michael Ang]

Should I check this in now or should someone pool this with other xpidl
changes?  Causing a rebuild to remove a dead code path seems a bit excessive.

Comment 6

[Mike McCabe]

I wouldn't worry about it.  You might try to check in at a time when not too
many people will be waiting to see their changes clear.

Comment 7

[Michael Ang]

Fix checked in.