Closed
Bug 626292
Opened 13 years ago
Closed 13 years ago
"Make description private" checkbox should set bz_private class on the comment box
Categories
(Bugzilla :: User Interface, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: reed, Assigned: dkl)
References
Details
Attachments
(1 file, 3 obsolete files)
|
2.52 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #626266 +++ The "Make description private" checkbox needs to set the 'bz_private' class on the comment box when it's checked.
|
Assignee | |
Comment 1•13 years ago
|
||
Patch to add bz_private class to description when clicking comment privacy checkbox in enter_bug.cgi. Also fixes issue in show_bug.cgi when replying to a private comment where bz_private was not being added to the comment field there. Please review Dave
|
||
Comment 2•13 years ago
|
||
Comment on attachment 504793 [details] [diff] [review] Patch to add bz_private class to description/comment field (v1) I'm pretty sure that "document.changeform" is an old, deprecated syntax. Perhaps we should make updateCommentTagControl accept strings as well as objects. There are some YUI methods that will let you do this, like YUI.util.Dom.get, I believe.
Attachment #504793 -
Flags: review?(mkanat) → review-
|
|
||
Updated•13 years ago
|
Target Milestone: --- → Bugzilla 4.0
|
|
Assignee | |
Comment 3•13 years ago
|
||
New patch addressing Max's suggested changes. Dave
Attachment #504793 -
Attachment is obsolete: true
Attachment #505691 -
Flags: review?(mkanat)
|
|
Assignee | |
Comment 4•13 years ago
|
||
New patch that simply takes a string for the field to add the bz_private class to as the second argument to updateCommentTagControl(). Dave
Attachment #505691 -
Attachment is obsolete: true
Attachment #505698 -
Flags: review?(mkanat)
Attachment #505691 -
Flags: review?(mkanat)
|
|
Assignee | |
Comment 5•13 years ago
|
||
Simplified to use YAHOO.util.Dom.addClass(field, 'bz_private') instead of using YAHOO.util.Dom.get(field). Dave
Attachment #505698 -
Attachment is obsolete: true
Attachment #505702 -
Flags: review?(mkanat)
Attachment #505698 -
Flags: review?(mkanat)
|
|
||
Updated•13 years ago
|
Attachment #505702 -
Flags: review?(mkanat) → review+
|
|
||
Updated•13 years ago
|
Flags: approval4.0+
Flags: approval+
|
|
Assignee | |
Comment 6•13 years ago
|
||
trunk: Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/ modified js/field.js modified template/en/default/bug/edit.html.tmpl modified template/en/default/bug/create/create.html.tmpl Committed revision 7658. 4.0: Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/4.0/ modified js/field.js modified template/en/default/bug/edit.html.tmpl modified template/en/default/bug/create/create.html.tmpl Committed revision 7516.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•