626579 - Java isn't properly disabled in manual installs

Status: RESOLVED FIXED

(Camino Graveyard :: Plug-ins, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Contrary to our belief after timestamp-checking (bug 625220 comment 7), manual installs of 2.1a1 do not actually disable Java.

In my case, the checkbox was unchecked, but Java was still active (checking the checkbox did not kill the active applet, so at least for me there were no sync issues like with offline mode).  I believe philippe had a slightly different experience.

[01:25am] smorgan: So manual updates don't work. I wonder why
[01:26am] smorgan: I guess file a bug; I can add some prodding code for b1
[01:26am] smorgan: We can have PreferenceManager do an explicit check once

Comment 1

[philippe (part-time)]

(In reply to comment #0)
> I believe philippe had a slightly different
> experience.

I had the same experience actually. The new pref didn't kick in until I manually checked the box ON (there was a slight flicker on the applet while doing so) and then OFF (and that killed the applet).

Comment 2

[Stuart Morgan]

Attachment: fix

Does a one-time resync of the Gecko state to the prefs.

Also removes our oldest pref migration, since it dates back at least to early 2007, and if someone hasn't updated in the last four years, they probably aren't going to.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(Might we want to hold off on checking this in until bug 633684 and bug 632278 are ready, if pink's sr beats my having those ready, so that we don't have to rev the prefs version from 2 to 6 in the course of Camino 2.1 development?)

Comment 4

[Stuart Morgan]

Comment on attachment 512700 [details] [diff] [review]
fix

Removing sr request since this one is trivial.

Comment 5

[Stuart Morgan]

Landed http://hg.mozilla.org/camino/rev/94b0aaef1504