Closed Bug 626658 Opened 14 years ago Closed 13 years ago

Add (take) link to bug edit page to allow quick assigning to the current user

Categories

(Bugzilla :: Creating/Changing Bugs, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: dkl, Assigned: dkl)

References

Details

Attachments

(1 file, 1 obsolete file)

Add a new (take) link next to the (edit) link for the bug's assignee. This will allow the current user to quickly add their own email address to the assignee field using javascript functionality. If the user is already the assignee of the bug, the (take) like will not be displayed.

Patch attached.
Dave
Attachment #504717 - Flags: review?(mkanat)
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
Assignee: create-and-change → dkl
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 4.2
Comment on attachment 504717 [details] [diff] [review]
Patch to add (take) link to the assignee field (v1)

Cool! Looks good, except that we shouldn't be doing things like "document.changeform.assigned_to". Instead this should probably have a separate function that it calls, that uses document.getElementById.
Attachment #504717 - Flags: review?(mkanat) → review-
New patch with Max's suggested changes. I added a new argument to showEditableField that allows overriding and setting the input fields value.

Please review. If you think this would be better reviewed by Guy then feel free to change the requestee.

Dave
Attachment #504717 - Attachment is obsolete: true
Attachment #505101 - Flags: review?(mkanat)
Comment on attachment 505101 [details] [diff] [review]
Patch to add (take) link to the assignee field (v2)

>- * var ContainerInputArray[0]: the conainer that will be hidden usually shows the (edit) text
>+ * var ContainerInputArray[0]: the conainer that will be hidden usually shows the (edit) or (take) text

container.
Comment on attachment 505101 [details] [diff] [review]
Patch to add (take) link to the assignee field (v2)

Looks good and works well. :-)
Attachment #505101 - Flags: review?(mkanat) → review+
Flags: approval+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla      /trunk/
modified js/field.js
modified template/en/default/bug/edit.html.tmpl                           Committed revision 7656.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Blocks: 734997
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: