Closed
Bug 626758
Opened 13 years ago
Closed 13 years ago
XMLObject::_toXMLString removes namespaces incorrectly
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stejohns, Assigned: stejohns)
Details
(Whiteboard: WE:2787930)
Attachments
(1 file)
|
941 bytes,
patch
|
rreitmai
:
review+
wsharp
:
feedback+
|
Details | Diff | Splinter Review |
quoth Werner:
this loop in XMLObject::_toXMLString is backwards:
while (namespaceLength > newNamespaceArray.length())
newNamespaceArray.removeLast();
it should be:
while (newNamespaceArray.length() > namespaceLength)
newNamespaceArray.removeLast();
prior to the NamespaceList change it was:
newNamespaceArray->setLength (namespaceLength);
|
Assignee | |
Updated•13 years ago
|
Whiteboard: WE:2787930
|
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → stejohns
Attachment #504831 -
Flags: review?(rreitmai)
Attachment #504831 -
Flags: feedback?(wsharp)
|
||
Updated•13 years ago
|
Attachment #504831 -
Flags: feedback?(wsharp) → feedback+
|
||
Comment 2•13 years ago
|
||
Comment on attachment 504831 [details] [diff] [review] Patch r+ seems correct.
Attachment #504831 -
Flags: review?(rreitmai) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
TR 5805:a191bb3a8ed3
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•