626792 - Content view contentWidth/Height do not update immediately after scaling

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Benjamin Stover (:stechz)]

This is because the properties are updated only during painting.

See:
https://bugzilla.mozilla.org/attachment.cgi?id=501722&action=diff

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

What's the bug here?  Who's affected and to what extent?  "Scaling": where, fuzzy-scaling in the chrome process?

Comment 2

[Benjamin Stover (:stechz)]

(In reply to comment #1)
> What's the bug here?  Who's affected and to what extent?  "Scaling": where,
> fuzzy-scaling in the chrome process?

Fennec is affected and nothing else really. We have code that will set fuzzy scale and then scroll to a place based on how big it thinks the content is. If contentWidth/contentHeight aren't adjusted immediately, then we are clipping scroll values to the wrong numbers.

Comment 3

[Benjamin Stover (:stechz)]

Attachment: Content view contentWidth/Height do not update immediately after scaling

Comment 4

[Benjamin Stover (:stechz)]

Roc: this patch ensures that nsContentView's properties (that are in "shadow space") are immediately updated once scale is changed.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 546227 [details] [diff] [review]
Content view contentWidth/Height do not update immediately after scaling

Review of attachment 546227 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 546227 [details] [diff] [review]
Content view contentWidth/Height do not update immediately after scaling

r=mbrubeck for the mobile patch

Comment 7

[Benjamin Stover (:stechz)]

Pushed to inbound http://hg.mozilla.org/integration/mozilla-inbound/rev/cf0b3329da8c

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/cf0b3329da8c