627209 - Support non-bootstrapped (XUL) extensions on Mozilla 2

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Nickolay_Ponomarev]

All that's needed is:
- let the extension specify a static classID for the harness component (bug 626059).
- add a NSGetFactory() entry point
- make the harness component register for profile-before-changed instead of  app-startup to run on startup, since only the former works on both 1.9.2 and 2.0

I'm also going to make this tested by adding a XUL extension template for 'cfx init' and including it in the test run, but that work is not ready yet.

Comment 1

[Nickolay_Ponomarev]

https://github.com/mozilla/addon-sdk/pull/96

Comment 2

[Nickolay_Ponomarev]

> I'm also going to make this tested by adding a XUL extension template for 'cfx
> init' and including it in the test run, but that work is not ready yet.

It's here by the way: https://github.com/nickolay/addon-sdk/tree/WIP-xul-extensions (will be rebased)

Comment 3

[Nickolay_Ponomarev]

Attachment: pointer to the pull request

Atul, could you take a look?

Comment 4

[Atul Varma [:atul]]

Overall, this looks cool, but I'm so rusty on the intricacies of the original code you're modifying that I'm not sure I'm qualified to r+ it... Then again, I'm not sure if *anyone* is super familiar with this code anymore.

The main things I think we need to make sure still work with this patch applied:

  * 'cfx develop'. Often changes to this part of the code unintentionally break 'cfx develop', in part because it makes deep hooks into this code.

  * The Add-on builder helper addon at https://github.com/mozilla/addon-builder-helper. It relies on the same 'development-mode' package that 'cfx develop' does, so when 'cfx develop' breaks, it does too.

  * Normal restartless addon functionality (obviously).

As long as those things still work, I think this patch is probably good to go. Thanks for working on this, Nickolay!

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Nickolay: have you managed to test the functionality Atul mentions in comment 4 to make sure it still works?

Brian: I noticed you commented in the pull request.  Any insight into potential regressions from this change?

Comment 6

[Nickolay_Ponomarev]

Myk, not yet (I think I tested 1 and 3, but not 2 before opening the pull request; I'd like to retest to make sure). This will be first thing I'll do when I have time.

Brian's comment was for the commit already landed in bug 626059. That comment was not news to me and there shouldn't be any regressions from that change.

Comment 7

[Nickolay_Ponomarev]

OK, I tested the scenarios Atul mentioned in comment 0 using:
- Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0b13pre) Gecko/20110226 Firefox/4.0b13pre
- https://github.com/mozilla/addon-builder-helper/commit/1fce8da13eed829fc03fa3c28608e0d83e31cf03
- https://github.com/mozilla/addon-sdk/commit/e0d46ecdbd3e7218bc51468883efe292545e2528

Nothing seems broken: I built the addon builder helper with 'cfx xpi', installed it into a running Firefox instance and was able to install/uninstall an addon from https://builder.addons.mozilla.org/addon/1000529/latest/ (the addon bar icon appeared and disappeared).

cfx develop followed by cfx {run|test} --use-server worked fine (judging by the widget in the status bar again) for reddit-panel example.

Comment 8

[Nickolay_Ponomarev]

I meant comment 4, not 0, of course.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 510128 [details]
pointer to the pull request

My tests similarly suggest that this change is benign.  And profile-after-change is the recommended notification for extensions to observe <https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_2.0#Category_registration>.  So this seems like a fine change.

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Merge commit:

https://github.com/mozilla/addon-sdk/commit/491a6ea208bde78c75a93fb3339ed97660ed98f6

Topic branch commits:

https://github.com/mozilla/addon-sdk/commit/e8fff2b625dcc4fd71b5892dd26a9c3c70885069

https://github.com/mozilla/addon-sdk/commit/14a6e98f1aee8c12e7b6e42d70816073471c7f7c

https://github.com/mozilla/addon-sdk/commit/e1daaff541c7a00e729ab50abd2bf8ac878e6eb6

Comment 11

[Nickolay_Ponomarev]

Thanks, Myk!