627755 - No resizer when status bar is turned off

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Bug 489303 has made it possible to turn on scrollbars on the web page when the status bar is turned off.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philip Chee]

Comment on attachment 505822 [details] [diff] [review]
Proposed patch

> +  getBrowser().showWindowResizer = !window.fullScreen &&
> +      !isElementVisible(document.getElementById("status-bar"));

I can never remember the indentation rules for this sort of situation. Is four spaces correct here?

While testing this patch I ran into Bug 626997. Perhaps you need to port attachment 505499 [details] [diff] [review] as well.

Comment 3

[[e-mail]]

Attachment: With maximise fix

There is an edge case where the resize listener doesn't work but somehow I doubt that users will manually resize their browser to the particular size.

Comment 4

[Philip Chee]

Comment on attachment 506214 [details] [diff] [review]
With maximise fix

r=me

>    addEventListener("PopupCountChanged", UpdateStatusBarPopupIcon, true);
>  
>    addEventListener("AppCommand", HandleAppCommandEvent, true);
>  
> +  addEventListener("resize", updateWindowResizer, false);

Optionally remove the blank lines in between these addEventListener(s) on checkin.

Comment 5

[[e-mail]]

Pushed changeset 0c665572476a to comm-central.