Closed Bug 627880 Opened 13 years ago Closed 10 years ago

Move email-linkifying code from users.js to somewhere common and ensure it doesn't regress anything

Categories

(support.mozilla.org :: Code Quality, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: paulc, Unassigned)

Details

users.js has some code that turns the output of users.helpers.public_email into a clickable mailto: link.

We are already using this in the AoA.

It would be good to ensure it doesn't break any other elements of class "email" when we pull it out to some common place between apps (or rename the script).
Or just rename users.js=>email.js. Frankly, there's nothing wrong with us having small files we then concat into the bigger bundles (is there?) but the filename should roughly reflect what it is.
(In reply to comment #1)
> Or just rename users.js=>email.js. Frankly, there's nothing wrong with us
> having small files we then concat into the bigger bundles (is there?) but the
> filename should roughly reflect what it is.
Yeah, that's totally fine. It could go in libs/email.js and be called from main.
Target Milestone: 2011Q1 → 2011Q2
Target Milestone: 2011Q2 → 2011Q3
Assignee: nobody → mozilla+bugzilla
Target Milestone: 2011Q3 → ---
Assignee: paul → nobody
this hasn't bothered me.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.