627927 - Set fallback status immediately to prevent sending of wrong update type

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now we first retrieve the patchInfo property in the teardown module of test2.js. Because it internally checks for a valid update an exception gets thrown and we don't set the update type to fallback. We will have to move the update to the update's fallback property to setupModule to always make sure to have the correct update type selected.

Patch upcoming.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1 [checked-in]

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For an example how it looks like at the moment see the given URL.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Backport (1.9.1) [checked in]

Anthony, can you please check-in once reviewed? Thanks.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 506011 [details] [diff] [review]
Patch v1 [checked-in]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/ee8b95555fae (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/4ceca6f8801c (1.9.2)

Comment 5

[u279076]

Comment on attachment 506016 [details] [diff] [review]
Backport (1.9.1) [checked in]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/a191dfd19b9d [mozilla1.9.1]

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Anthony. Closing as fixed.