Closed
Bug 627959
Opened 13 years ago
Closed 13 years ago
check strings in compartment checker, fix failures
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: luke, Assigned: luke)
Details
(Whiteboard: [sg:critical?][hardblocker][fixed-in-tracemonkey])
Attachments
(3 files)
|
2.13 KB,
patch
|
Details | Diff | Splinter Review | |
|
1006 bytes,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
|
7.85 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
The attached patch fails pretty hard on try server. Gotta catch 'em all!
|
Assignee | |
Comment 1•13 years ago
|
||
IIUC, compartment mismatches are hardblockers. I was wrong about 'fails pretty hard', though, there are two asserts on a whole try server run.
blocking2.0: --- → betaN+
Whiteboard: hardblocker
|
|
Assignee | |
Comment 3•13 years ago
|
||
Let's see if it try's clean now.
Attachment #506571 -
Flags: review?
|
|
Assignee | |
Updated•13 years ago
|
Attachment #506571 -
Flags: review? → review?(wmccloskey)
Attachment #506571 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/f3e687a7fe94 http://hg.mozilla.org/tracemonkey/rev/8e7cf978049e http://hg.mozilla.org/tracemonkey/rev/5836983f910a
Whiteboard: hardblocker → [hardblocker][fixed-in-tracemonkey]
|
||
Updated•13 years ago
|
Whiteboard: [hardblocker][fixed-in-tracemonkey] → [sg:critical?][hardblocker][fixed-in-tracemonkey]
|
||
Comment 6•13 years ago
|
||
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/f3e687a7fe94 http://hg.mozilla.org/mozilla-central/rev/8e7cf978049e http://hg.mozilla.org/mozilla-central/rev/5836983f910a
|
|
||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Updated•9 years ago
|
Group: core-security
You need to log in
before you can comment on or make changes to this bug.
Description
•