628616 - Make sure suggestions from <datalist> are shown in Firefox Mobile UI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement, P3)

Description

[Mounir Lamouri (:mounir)]

With <datalist> and the list attribute on the input element, authors can provide suggestions to the user. On Firefox Desktop, they are shown like autocomplete suggestions. It would be nice to have them shown in Firefox Mobile given that authors should check if list and datalist are available and might assume that it will work on Firefox Mobile.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Testcase

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Is it going to break Fennec? :D

Comment 3

[Mounir Lamouri (:mounir)]

It should not ;)

Comment 4

[Mounir Lamouri (:mounir)]

I don't think this should be considered as an enhancement: feature detection will return a false positive on Firefox Mobile if it's not implemented.

Comment 5

[Martijn Wargers (dead)]

But it is implemented in Firefox Mobile, isn't it? There's just no UI for it, atm.

Comment 6

[Mounir Lamouri (:mounir)]

(In reply to comment #5)
> But it is implemented in Firefox Mobile, isn't it? There's just no UI for it,
> atm.

It's implemented in Gecko and Firefox has an UI for it, not Firefox Mobile. That means you can't use the feature in Firefox Mobile.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I'm actually reworking the autocompletion UI for Firefox Mobile, I will have a look to see if I can fix that in the process

Comment 8

[Anthony Ricaud (:rik)]

If we can't implement a UI for <datalist>, we should show the content of the <datalist> element (as if it was not implemented).

I've recently fixed a similar bug in WebKit : https://bugs.webkit.org/show_bug.cgi?id=52214 and I'd be sad if Firefox made the same mistake :(

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch add support for the suggestions thought the new autocomplete mechanism. For the moment the suggestions have the same exact look as normal autocomplete results (probably need Madhava's for that)

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

This patch won't make it for Fennec 4. Please file another bug to do any type of work to disable datalist support from the platform for Fennec 4.0

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I have filled bug 638833 for moving to display: inline from  display: none; for the moment.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

any screenshots I can see?

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: screenshot

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

And the patch updated on trunk

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 523052 [details] [diff] [review]
Patch

Needs tests!

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Tests

Tests!

Comment 17

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/796cf934cfd1

Comment 18

[Andreea Pod]

Verified on build: Mozilla /5.0 (Android;Linux armv7l;rv:5.0a2) Gecko/20110414
Firefox/5.0a2 Fennec/5.0a2 
Device: LG Optimus 2X (Android 2.2)

The suggestion pop-up flickers when taping in the text field or when you dismiss the keyboard, can you see this too?