Closed Bug 628839 Opened 13 years ago Closed 13 years ago

Character counter is set to 0 by default and cannot submit text with any feedback

Categories

(Input :: General, defect, P1)

Product:
Input
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: aakashd, Assigned: wenzel)

Details

(Keywords: regression) 

Steps to Reproduce:
1. Go to input.stage.mozilla.com/feedback (with a UA of 3.6.13 or whatever the latest version of 3.6.x is)
2. Click on "Report a Broken Website"

Actual Results:
The character counter is set to 0. The idea submission form has the same issue and users can't submit any feedback.

Expected Results:
The character counter is set to 140.
I tracked down the regression, it was commit 0999c8c that moved the max_length attribute form the feedback form into an attribute on the description field. That's the right place for it to go, but the JS code does not expect that yet.
I fixed it and added unit tests to make sure the data attribute is filled correctly in both the beta and release view:

http://github.com/fwenzel/reporter/commit/da474cb

QA: You might want to add a selenium test that makes sure the submission buttons stay enabled for a small variety of input lengths.
Assignee: nobody → fwenzel
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified character count is set correctly for report a broken website and share an idea
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Component: Input → General
Product: Webtools → Input
You need to log in before you can comment on or make changes to this bug.