628845 - /beta path is doubled on /sites

Status: VERIFIED FIXED

(Input :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load http://input.stage.mozilla.com/en-US/beta/
2. Click on "Sites"

Expected Results:

http://input.stage.mozilla.com/en-US/beta/sites

Actual Results:

http://input.stage.mozilla.com/en-US/beta/beta/sites

(Double your betas, double your fun!)

Comment 1

[Rebecca Billings [:rbillings]]

Also seen in search, ex: http://input.stage.mozilla.com/en-US/beta/beta/search?product=firefox&q=speed

Comment 2

[Fred Wenzel [:wenzel]]

Possible that today's merge (from development to master) broke something. I'll be at a class all day tomorrow. Dave Dash, can you take a look?

Comment 3

[Fred Wenzel [:wenzel]]

Actually this is because the URL patterns for Sites have not been adapted to davedash's channel middleware yet.

Assigning this one to Michael: You want to remove the "beta/" from your URL patters in website_issues.urls, and instead hook up two views (one for beta, one for releases) to the same URL using the negotiate() function that Dave wrote for this purpose. Take a look at feedback.views to see how it works, and let me or Dave know if you have any questions!

Comment 4

[David Burns :automatedtester]

failing test on QA Hudson is showing this 

http://qa-selenium.mv.mozilla.com:8080/job/input%20stage/212/testReport/test_product_filter/SearchFirefox/test_product_filter_SearchFirefox_test_sites_can_be_filtered_by_all_expected_products_and_versions/

Comment 5

[Michael Kurze [:michaelk]]

Removed the depenency (it's totaly fixable before we have the release dashboard).
Thanks dave for taking this on, leaving it for you to mark fixed.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/fwenzel/reporter/commit/6a43400

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, guys -- our Hudson build went green: http://qa-selenium.mv.mozilla.com:8080/job/input%20stage/213/