629034 - [ro]Text cut off in Windows master password in Romanian language

Status: RESOLVED FIXED

(Mozilla Localizations :: ro / Romanian, defect)

Description

[Raul Nicolae Malea]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110125 Firefox/4.0b10pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110125 Firefox/4.0b10pre

1.In Addons Manager , search box text is not visible completed. 
2. After disabled Flash plug-ins , box for missing plug-ins is with incomplete text.

See in attachments.

Reproducible: Always

Steps to Reproduce:
1.Go to Addons manager in romanian localization
2.See text in search addons form
3.Disable flash all plugins
4. Go to in anyone website contains flash
5. Observe button with information about plugin missing
Actual Results:  
Text not visible completed

Expected Results:  
All text is completed visible

Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110125 Firefox/4.0b10pre ID:20110125030335

about:buildconfig
Source
Built from http://hg.mozilla.org/mozilla-central/rev/6a097e294828
Build platform
target
i686-pc-mingw32
Build tools
Compiler 	Version 	Compiler flags
d;D:\mozilla-build\msys\mozilla-build\python25\python2.5.exe -O e;D:\mozilla-build\msys\builds\moz2_slave\cen-w32-ntly\build\build\cl.py cl 	14.00.50727.762 	-TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
d;D:\mozilla-build\msys\mozilla-build\python25\python2.5.exe -O e;D:\mozilla-build\msys\builds\moz2_slave\cen-w32-ntly\build\build\cl.py cl 	14.00.50727.762 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800 -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
Configure arguments

--enable-application=browser --enable-update-channel=nightly --enable-update-packaging --enable-jemalloc --enable-tests

Graphics
      
Descrierea adaptorului NVIDIA GeForce 8600 GT 
ID furnizor 10de
ID dispozitiv 0402
RAM pentru adaptor 512
Drivere pentru adaptor nvd3dum nvwgf2um,nvwgf2um
Versiune driver 8.17.12.6099
Dată driver 10-16-2010
Direct2D activat true
DirectWrite activat true (6.1.7600.20830)
WebGL Renderer TransGaming Inc. -- ANGLE -- OpenGL ES 2.0 (git-devel Jan 25 2011 03:42:06)
Accelerare GPU Windows 1/1 Direct3D 10

Comment 1

[Raul Nicolae Malea]

Attachment: missing text in box for plugins

Comment 2

[Raul Nicolae Malea]

Attachment: not visible all letter in search box for addons

Comment 3

[Raul Nicolae Malea]

Luke, this bug is NOT a localisation bug. Translate text is completed and correct. BUT text not visible corect in addons manager search because form dimensions is SMALL.
Also, text for button for missing plugins is translated correct. Button is problem not texts!
Please see in attachments.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

The plugin issue isn't a bug: that's just the size of that widget, which is large enough that we don't show the infobar, but too small to see the text. Try crashing Flash (by killing the plugin container process) on YouTube to verify, though.

The cutoff in the add ons manager is most likely bug 627824

Comment 5

[Raul Nicolae Malea]

I reopened this bug. See https://bugzilla.mozilla.org/show_bug.cgi?id=627824#c23 and https://bugzilla.mozilla.org/show_bug.cgi?id=627824#c24

Comment 6

[Raul Nicolae Malea]

Attachment: letter cut in windows password

Comment 7

[Raul Nicolae Malea]

Anyone confirm this bug?

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Raul: in bug 627824 comment 24 you were told that the string needs to be 32-bytes, and is currently 33 bytes. So this is a l10n issue.

Comment 9

[Raul Nicolae Malea]

Thanks Mike.

Alex, can you fix this bug? Please observe string is high in two situations: search form in addons manager and window master password.
Also perhaps verifying string for all translated texts?

Comment 10

[Raul Nicolae Malea]

I proposed new translation for windows master password.

Comment 11

[Raul Nicolae Malea]

I proposed new translation for windows master password.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Clearing the flag; Alex, this should probably block your signoff for the romanian locale.

Comment 13

[Raul Nicolae Malea]

In Bulgarian language some problem.

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

the search field in the addons manager is now wider so as to give enough space to all localizations text (bug 630604), so this specific issue in this bug is fixed in nightlies.

Comment 15

[Raul Nicolae Malea]

(In reply to comment #14)
> the search field in the addons manager is now wider so as to give enough space
> to all localizations text (bug 630604), so this specific issue in this bug is
> fixed in nightlies.

Yes! Very good. Thanks Pascal and all.

Second part from this bug is resolved. Remaining text in master password windows. (similarly with bug 630604 - need large window).

Comment 16

[Josh Aas]

Clearing hardblocker from the whiteboard since this doesn't have blocking2.0+.

Comment 17

[Raul Nicolae Malea]

For resolved this bug need a large windows master password.

Comment 18

[Raul Nicolae Malea]

Increasing the window size is required for the master password. Abbreviation word translated is NOT a solution(e.g. device=dispozitiv ->disp.)

Comment 19

[Raul Nicolae Malea]

Any news? My suggestion is increasing windows dimensions.

Comment 20

[Jennifer Morrow [:Boriss] (UX)]

The text field in the add-ons manager should be the same default (if not exactly the same) length as the normal Firefox search field.  Would making the search box that large solve the problem, Raul?

Comment 21

[Myk Melez [:myk] [@mykmelez]]

Boriss: it sounds like the search field in the Add-ons Manager has been fixed in bug 630604, and the remaining problem is the appearance of the label in the master password dialog, i.e. the dialog that prompts you to enter your master password.

In English, the label in that dialog says "Please enter the master password for the Software Security Device.", which is a combination of the string "Please enter the master password for the %S." from CertPassPrompt <http://mxr.mozilla.org/mozilla-central/source/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#43> and the string "Software Security Device" from either PrivateTokenDescription <http://mxr.mozilla.org/mozilla-central/source/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#63> or InternalToken <http://mxr.mozilla.org/mozilla-central/source/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#76>.

In Romanian, the former string is translated to "Vă rugăm introduceți parola generală pentru %S." <http://mxr.mozilla.org/l10n-central/source/ro/security/manager/chrome/pipnss/pipnss.properties#43>, and the latter string is translated to "Dispozitiv software de securitate" <http://mxr.mozilla.org/l10n-central/source/ro/security/manager/chrome/pipnss/pipnss.properties#63>, so the label should read "Vă rugăm introduceți parola generală pentru Dispozitiv software de securitate."

But, as shown in attachment 508240 [details], it reads "Vă rugăm introduceți parola generală pentru Dispozitiv software de securitat."  The last "e" in the last word ("securitate") is missing.

This doesn't look like a problem of the window not being wide enough, given that the period after the last word isn't cut off, and because presumably this XUL dialog expands to fit the content it contains.

Instead, it appears that PrivateTokenDescription/InternalToken, which contain 33 ASCII characters, are being truncated to 32 characters, which is exactly what I would expect given the comments in pipnss.properties that those strings must fit into 32 bytes when converted to UTF-8 <http://mxr.mozilla.org/mozilla-central/source/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#44>.

  0        1         2         3   
  123456789012345678901234567890123
  Dispozitiv software de securitate

So the short-term fix for the issue is to reduce the size of the Romanian translation of "Software Security Device" from 33 UTF-8 bytes to 32 or less UTF-8 bytes.

(In the long term, it would be nice if the string didn't have such a length restriction, of course.)

Comment 22

[Phil Ringnalda (:philor)]

It's a nasty l10n requirement, but bug 320231 and bug 90956 comment 21 don't really make it sound like there's much choice.

Comment 23

[Raul Nicolae Malea]

Any news for this bug?

Comment 24

[Asa Dotzler [:asa]]

(In reply to comment #23)
> Any news for this bug?

If there is news for this bug, it will show up as a comment, an attachment, or a review in this bug, so you should be able to answer that question for yourself.

Comment 25

[Axel Hecht [:Pike]]

I'm pretty sure that the 32 byte limit is hard, Kai, can you confirm that?

If so, the Romanian team will need to make an effort to squeeze their localization into that limit, in those cases, we apparently can't do anything on the platform side. If I understood Kai right.

Comment 26

[Kai Engert (:KaiE:)]

Hard limit, please sqeeze your translation into 32 bytes, e.g. by using abbreviations.

Other ideas for "software security device" (that might give you a shorter translation):
- Software Key Store

Comment 27

[Raul Nicolae Malea]

(In reply to Kai Engert (:kaie) from comment #26)
> Hard limit, please sqeeze your translation into 32 bytes, e.g. by using
> abbreviations.
> 
> Other ideas for "software security device" (that might give you a shorter
> translation):
> - Software Key Store

OK. We try to squeeze this translation.

Alex or Cristi, you have any suggestions?

Comment 28

[Cristian Secară]

(regarding comment 21) The string "Vă rugăm introduceți parola generală pentru %S." in Romanian translation should be shorter, i.e. "Introduceți parola generală pentru %S.".

Reason: in Romanian we shall never use the excessively polite form, so the "Vă rugăm" part must be always avoided. There is also a written reference for this here (in Romanian) http://i18n.ro/Ghidul_traducatorului_de_software#Polite.C8.9Bea_excesiv.C4.83

Is this enough to solve the issue raised here ?

As a sidenote I am not sure if „parola generală” is the best translation for „master password”; maybe „parola principală” is a better variant ? (but I do not insist here)

Also in my opinion the string "Dispozitiv software de securitate" should became "dispozitivul software de securitate" because it makes the overall phrase more natural.

Cristi

Comment 29

[Cristian Secară]

(In reply to Cristian Secară from comment #28)

> Also in my opinion the string "Dispozitiv software de securitate" should
> became "dispozitivul software de securitate" because it makes the overall
> phrase more natural.

... except if this string is again used elsewhere in standalone form.

Cristi

Comment 30

[Alexandru Szasz]

Replaced 

Vă rugăm introduceți parola generală pentru dispozitivul software de securitate

with

Introduceți parola generală pentru dispozitivul software de securitate

in Firefox Aurora.

and shortned other similar texts in http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/0b33781d0bd3

Răzvan, please check.

Comment 31

[Raul Nicolae Malea]

(In reply to Alexandru Szasz from comment #30)
> Replaced 
> 
> Vă rugăm introduceți parola generală pentru dispozitivul software de
> securitate
> 
> with
> 
> Introduceți parola generală pentru dispozitivul software de securitate
> 
> in Firefox Aurora.
> 
> and shortned other similar texts in
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/0b33781d0bd3
> 
> Răzvan, please check.

Is very good! Thanks all!

Comment 32

[Raul Nicolae Malea]

In Firefox 10 beta this bug is still present. See in photo attached.

Comment 33

[Raul Nicolae Malea]

Attachment: Letters missing in master password windows

Comment 34

[Raul Nicolae Malea]

Alex, 3 letters missing: "ate". Please check.

Comment 35

[Alexandru Szasz]

Shortened the text by droping Enter. It's obvious you need to enter something there. in http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/b7d78dfe2d6a

Comment 36

[Raul Nicolae Malea]

Sorry , this bug is till present in Mozilla/5.0 (Windows NT 6.1; rv:11.0a2) Gecko/20120112 Firefox/11.0a2 ID:20120112042007
See in attachment.

Comment 37

[Raul Nicolae Malea]

Attachment: Letters missing in master password window in Aurora

Comment 38

[Raul Nicolae Malea]

Any suggestions for this?  Now, 3 letters missing: "ate". However, I think the translation is still too long.

Comment 39

[Raul Nicolae Malea]

Two years! :) Congratulations!

Comment 40

[Raul Nicolae Malea]

Resolved in: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/410aa81f64a3 by:

Parola generală (eliminated word „pentru„) and „dispozitiv software de securitate”. 
So, is a „Microsoft” translation but ... :(

After verified in Aurora I closed this bug.

Comment 41

[Cristian Silaghi]

You could use "pt." instead of removing "pentru". At least, it makes sense for users. "Pt." it's a known abbreviation for "pentru" (eng. "for").

Best Regards,
Cristian Silaghi

Comment 42

[Raul Nicolae Malea]

(In reply to Cristian from comment #41)
> You could use "pt." instead of removing "pentru". At least, it makes sense
> for users. "Pt." it's a known abbreviation for "pentru" (eng. "for").
> 
> Best Regards,
> Cristian Silaghi

Voi verifica mâine dacă încap acum textele. Ar trebui să apară așa: „Parola generală dispozitiv software de securitate.”

Comment 43

[Raul Nicolae Malea]

Hmm ....last 3 letter „ate” missing. Problem are from „Software Security Device” (dispozitiv software de securitate) because # 32 bytes long after conversion to UTF8

So, I not understanding. In last time missing one letter („e”), see in comment 21.

Also, not understanding where enter something by comment 35.

This bug is still present.

For moment, do not have any idea.

Comment 44

[Raul Nicolae Malea]

Now, translate is: „Vă rugăm introduceți parola generală pentru disp. software de securitate”. (commited in http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/81222a554ed9) 

Any suggestions?

Comment 45

[Raul Nicolae Malea]

Closed bug for moment. Thanks all.