Open
Bug 629760
Opened 13 years ago
Updated 2 years ago
Add a note about preferring services.h over do_GetService
Categories
(Core :: General, defect)
Tracking
()
NEW
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
(Whiteboard: not-ready)
Attachments
(1 file)
558 bytes,
patch
|
taras.mozilla
:
review+
benjamin
:
review-
benjamin
:
approval2.0-
|
Details | Diff | Splinter Review |
I had trouble remembering about mozilla::services::... so add a note to do_GetService()
Assignee | ||
Updated•13 years ago
|
Attachment #507967 -
Attachment is patch: true
Attachment #507967 -
Attachment mime type: application/octet-stream → text/plain
Attachment #507967 -
Flags: review?(tglek)
Updated•13 years ago
|
Attachment #507967 -
Flags: review?(tglek) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #507967 -
Flags: approval2.0?
Comment 1•13 years ago
|
||
Comment on attachment 507967 [details] [diff] [review] Add a note about preferring services.h over do_GetService This comment is not specific enough. mozilla::services is only available from within libxul, and this header is used by extensions.
Attachment #507967 -
Flags: review-
Attachment #507967 -
Flags: approval2.0?
Attachment #507967 -
Flags: approval2.0-
Updated•13 years ago
|
Assignee: nobody → jmuizelaar
Whiteboard: not-ready
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•