629847 - treeclosure hook fetches 2MB of HTML to get at a few hundred bytes that are in TreeName/status.html

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Even though the treeclosure hook doesn't hit nearly as often as tbpl, so it didn't feel the need to make a separate status.html static file like tbpl did, the hook really should take advantage of it - fetching the whole waterfall to get a the word "CLOSED" is rather excessive.

Untested, since I don't know how to test it, but I did at least verify that all the URLs work.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 508071 [details] [diff] [review]
Fix v.1

Seems totally reasonable, and we already have tests that cover this (they obviously don't hit the live Tinderbox page, or they wouldn't make very good tests), but you will have to adjust the URLs in the tests to match your changes here:
http://hg.mozilla.org/hgcustom/hghooks/file/04b0488534f5/runtests.py#l230

The redirect method there gives a URL and its contents, and causes the test to expect that that URL will be the next one fetched, and return that string as the URL contents:
http://hg.mozilla.org/hgcustom/hghooks/file/04b0488534f5/runtests.py#l192

You can run the tests with "python runtests.py".

r=me with the tests fixed.

Comment 2

[Justin Wood (:Callek)]

Attachment: patch for c-c hook as well.

Comment 3

[Justin Wood (:Callek)]

Attachment: [checked in] patch for c-c hook as well. (with test fixed for CC hook)

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 508155 [details] [diff] [review]
[checked in] patch for c-c hook as well. (with test fixed for CC hook)

I've pushed this as I'm reviewing another patch that is going to add to the tests, so may as well get this url changed first.

Comment 5

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/hgcustom/hghooks/rev/63a618e9a3d3

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/1e4384187eb4
https://hg.mozilla.org/hgcustom/version-control-tools/rev/eeefa6de5fbb