Closed
Bug 629870
Opened 13 years ago
Closed 13 years ago
Drop support for globalCompositeOperation=over,clear
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
VERIFIED
FIXED
mozilla7
| Tracking | Status | |
|---|---|---|
| firefox7 | + | --- |
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
()
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
3.93 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
http://www.w3c-test.org/html/tests/approved/canvas/2d.composite.operation.clear.html
Summary: Drop support for globalCompositeOperation=over → Drop support for globalCompositeOperation=over,clear
Er what? Why did these get removed?
|
|
Assignee | |
Comment 3•13 years ago
|
||
They were never in the spec, AIUI. For reference: http://www.whatwg.org/specs/web-apps/2005-09-01/#compositing http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2007-June/012063.html http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2008-January/013804.html
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 510678 [details] [diff] [review] Patch v1 You're also removing "darker" from the getter. Is that safe since the setter never sets it?
Attachment #510678 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
I just missed the getter in bug 571532. I don't believe that change has an observable effect.
Depends on: post2.0
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 7•13 years ago
|
||
Attachment #510678 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
|
||
Comment 8•13 years ago
|
||
What do other browsers do?
|
||
Updated•13 years ago
|
Whiteboard: [not-ready-for-cedar]
|
|
Assignee | |
Comment 9•13 years ago
|
||
The last time I tested, Chrome supported "clear", IE, and Opera don't. None of Chrome, IE and Opera supported "over". I'm fine with waiting another cycle, as Boris suggested.
No longer depends on: post2.0
Keywords: checkin-needed
Whiteboard: [not-ready-for-cedar] → [need gk2.2 ship]
|
||
Updated•13 years ago
|
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 10•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/25508c9bd01c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [need gk2.2 ship]
Target Milestone: --- → mozilla7
|
|
||
Comment 11•13 years ago
|
||
We don't actually document these, so I've simply mentioned their removal on Firefox 7 for developers.
Keywords: dev-doc-needed → dev-doc-complete
tracking-firefox7:
--- → +
|
||
Comment 12•13 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0 I was trying to verify this on the QA side and by loading the page from Comment 1 I get "clear" and a "Passed" result under the "Actual output". Can anyone say what is expected to be seen for the test example in comment 1, or is there another testcase that can be used to verify the fix? Thanks!
|
|
Assignee | |
Comment 13•13 years ago
|
||
The testcase in comment 1 should have a green background, and say * Passed below the image.
Flags: in-testsuite+
|
|
||
Comment 14•13 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0 Based on Comment 13 - Verified issue on Win XP, Win 7, Ubuntu 11.04 and Mac OS X 10.6 using the test case provided in Comment 1. Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•