630062 - Don't throw on setting lineWidth and ignore non-positive values

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

This patch makes us pass

http://www.w3c-test.org/html/tests/approved/canvas/2d.line.width.invalid.html

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Hmm, why lineWidth doesn't throw but arc should throw (Bug 630068).
Sounds like an inconsistency in the API, which should be fixed in the spec.
But perhaps there is some reason for this behavior.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

It seems like attributes don't throw, and methods do. That seems reasonable.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Ok, that makes at least some sense.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Thanks!

Comment 5

[Jonathan Watt [:jwatt]]

http://hg.mozilla.org/mozilla-central/rev/22aa43f18646

Comment 6

[Eric Shepherd [:sheppy]]

Added note to:

https://developer.mozilla.org/en/DOM/CanvasRenderingContext2D#Notes

And listed the change on Firefox 4 for developers.