Closed
Bug 630167
Opened 13 years ago
Closed 13 years ago
update Polish L10n files for DOMi Bug 615156
Categories
(Mozilla Localizations :: pl / Polish, defect)
Mozilla Localizations
pl / Polish
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adriank, Assigned: adriank)
References
Details
Attachments
(1 file, 1 obsolete file)
1.09 KB,
patch
|
crussell
:
review+
marcoos
:
review+
|
Details | Diff | Splinter Review |
The Polish localization files for the DOM Inspector have to be updated and "pl" should be added back to "ALL_LOCALES" because of DOMi Bug 615156.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #508375 -
Flags: review?(Sevenspade)
Attachment #508375 -
Flags: feedback?(marcoos+bmo)
Comment 2•13 years ago
|
||
Comment on attachment 508375 [details] [diff] [review] patch v1 >+<!ENTITY screenXCoord.label "ekran: x"> >+<!ENTITY screenYCoord.label "ekran: y"> Is this best? I don't speak Polish, but if there's a more natural way to communicate these that allows you to drop the colons (which suggest to me that the choice+word order might be a little "forced"), go with it instead.
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to comment #2) > Comment on attachment 508375 [details] [diff] [review] > patch v1 > > >+<!ENTITY screenXCoord.label "ekran: x"> > >+<!ENTITY screenYCoord.label "ekran: y"> > > Is this best? I don't speak Polish, but if there's a more natural way to > communicate these that allows you to drop the colons (which suggest to me that > the choice+word order might be a little "forced"), go with it instead. Yes, it's clearly not the best... The best would probably be: +<!ENTITY screenXCoord.label "współrzędna pozioma ekranu"> +<!ENTITY screenYCoord.label "współrzędna pionowa ekranu"> But I'm not sure, if there is enough space for that...?
Comment 4•13 years ago
|
||
Yeah, "ekran: x" sounds weird and I wouldn't probably understand it. At least, not instantly. Version from comment 3 seems OK, but shouldn't you update xCoord.label and yCoord.label to match, i.e. drop the "x" and "y" completely and use "współrzędna pozioma/pionowa" in all of these entities?
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to comment #4) > Yeah, "ekran: x" sounds weird and I wouldn't probably understand it. At least, > not instantly. > > Version from comment 3 seems OK, but shouldn't you update xCoord.label and > yCoord.label to match, i.e. drop the "x" and "y" completely and use > "współrzędna pozioma/pionowa" in all of these entities? Hmmm, makes sense. I'll try first, if this fits in the available space.
Assignee | ||
Comment 6•13 years ago
|
||
patch includes the feedback from the comments
Attachment #508375 -
Attachment is obsolete: true
Attachment #509167 -
Flags: review?(Sevenspade)
Attachment #508375 -
Flags: review?(Sevenspade)
Attachment #508375 -
Flags: feedback?(marcoos+bmo)
Assignee | ||
Updated•13 years ago
|
Attachment #509167 -
Flags: review?(marcoos+bmo)
Updated•13 years ago
|
Attachment #509167 -
Flags: review?(marcoos+bmo) → review+
Updated•13 years ago
|
Attachment #509167 -
Flags: review?(Sevenspade) → review+
Assignee | ||
Comment 7•13 years ago
|
||
pushed: https://hg.mozilla.org/dom-inspector/rev/6f8f919b58cb thanks
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•