Closed
Bug 630271
Opened 13 years ago
Closed 13 years ago
Throw a TYPE_MISMATCH_ERR on createPattern(null)
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
()
Details
(Keywords: dev-doc-complete, html5)
Attachments
(1 file, 1 obsolete file)
2.43 KB,
patch
|
Details | Diff | Splinter Review |
This makes us pass http://www.w3c-test.org/html/tests/approved/canvas/2d.pattern.image.null.html http://www.w3c-test.org/html/tests/approved/canvas/2d.pattern.image.undefined.html
Flags: in-testsuite+
Attachment #508466 -
Flags: review?(Olli.Pettay)
Updated•13 years ago
|
Attachment #508466 -
Flags: review?(Olli.Pettay) → review+
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #508466 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
Updated•13 years ago
|
Whiteboard: [not-ready-for-cedar]
Assignee | ||
Comment 2•13 years ago
|
||
Boris: not-ready-for-cedar as in post 2.2?
Comment 3•13 years ago
|
||
That was my thinking on the "it makes us throw where we don't throw now" premise. But I would be open to being convinced otherwise here.... (e.g. if my premise is wrong or if we have good reason to believe that no one depends on our old behavior).
Assignee | ||
Comment 4•13 years ago
|
||
We already throw NS_ERROR_NOT_AVAILABLE, this is just a change of which exception we throw.
Assignee | ||
Updated•13 years ago
|
Whiteboard: [not-ready-for-cedar]
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/15329bcef8d0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Updated•13 years ago
|
Keywords: dev-doc-needed
Comment 6•13 years ago
|
||
https://developer.mozilla.org/en/DOM/CanvasRenderingContext2D#Notes
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•