630341 - clear private data doesn't clear "tabs from last time"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Any tabs present in the "last time" list aren't cleared if you hit clear private data.  The STR are a bit weird:

- open slashdot.org
- hit home to suspend fennec, kill fennec (using white killer or similar)
- restart fennec, the old tab is opened as part of session restore
- close tab  -- it's now listed in "undo close tab", no other tabs are open and you're looking at the home screen, which has the tab in "tabs from last time"
- hit clear private data
- hit home to suspend fennec and kill fennec
- restart fennec

at that point, the tab still shows up in "tabs from last time" even though everything else is cleared.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

"tabs from last time" is not considered private data. we load the data from the session store json file.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

ok, but the tab was closed already even -- why is it even appearing in tabs from last time?

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(regardless, that's unexpected that your set of tabs is not considered "private data"!)

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Vlad asked to comment on desktop sessionstore... FWIW that clears closed tabs & windows when we get browser:purge-session-history.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Using the desktop session store as a guide I added support for browser:purge-session-history as follows:
1. Always clear the sessionstore.js and .bak files when we get the notification
2. If we are shutting down, we are done
3. Drop any data about closed tabs, Fennec doesn't track windows since there is only one
4. re-save the state after step #3

Since we do #4, we will remember any tabs still open when the "Clear" private data button is pressed. If Fennec supported "Clear private data on shutdown" we would not.

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 512913 [details] [diff] [review]
patch

>+        for (let ix in this._windows)
>+          this._windows[ix].closedTabs = [];

Nit: I prefer "for (let [ix, win] in Iterator(this._windows))" because it is less fragile against people monkeying with prototypes.  (I know the above pattern is used elsewhere in the file; you don't have to fix it everywhere.)

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

changed to use Iterator and pushed:
http://hg.mozilla.org/mobile-browser/rev/ac63b2800409

Comment 8

[Ioana Chiorean]

build id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre)
Gecko/20110304 Firefox/4.0b13pre Fennec /4.0b6pre

The sites are not cleared instantly: 
- after clean data go to url bar
- in the awesome list the tabs from last time are still there
- tab other category: Bookmarks /History/Desktop and return to all pages or type some text 

-> the tabs from last time are not present anymore.

is this the expected ? 

I guess they should be deleted almost instantly without tapping something else

Comment 9

[Matt Brubeck (:mbrubeck)]

(In reply to comment #8)
> The sites are not cleared instantly: 
> - after clean data go to url bar
> - in the awesome list the tabs from last time are still there
> - tab other category: Bookmarks /History/Desktop and return to all pages or
> type some text 
> -> the tabs from last time are not present anymore.

This is bug 567121.

Comment 10

[Andreea Pod]

VERIFIED FIXED on:
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110316
Firefox/4.0b13pre Fennec /4.0b6pre
Device: HTC Desire

The tabs are cleared even if you don't press "Clear" button from preferences:
-open more then two tabs
-quit Fennec with all tabs opened using Quit Fennec add-on 
-open Fennec (you will see the tabs from last time)
-quit Fennec again and reopen it

-> no tabs from last time present 

is this the expected result?