630364 - "Launch Application" dialog when using youtube (android/mobile version)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

When I click on a video, i get a ugly dialog that tells me that I need to launch an application to play the video.

I think we should just special case this url (vnd.youtube intent).

Comment 1

[Doug Turner (:dougt)]

Attachment: m-c changes

Comment 2

[Doug Turner (:dougt)]

Attachment: m-b change

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 510360 [details] [diff] [review]
m-b change

I thought you said this didn't work?

Comment 4

[Doug Turner (:dougt)]

w/ the m-c change it does

Comment 5

[Doug Turner (:dougt)]

the basic problem is that the type of the nsMIMEInfoAndroid is always null (because it is created with an empty string).  This m-c allows type to return something sane for different mime types.

Right now all the pref "network.protocol-handler.warn-external.*" and related mime-type based preferences do not work on android.

So, tel: and mailto:, which should not prompt the user because we set the preferences here:

http://mxr.mozilla.org/mobile-browser/source/app/mobile.js#108

dose not work -- and we prompt the user.  I'm not sure if this ever worked.  I tried b1, b2, b3, and b4.  None did the right thing.


The windows implementation also does something similar -- basically if there isn't a mimetype, then it uses a scheme.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 510358 [details] [diff] [review]
m-c changes

https://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/nsExternalHelperAppService.cpp#1173

the external helper app service assumes that the type of a protocol handler is its scheme.

one nit, please rename mMimeType to mType, since its not always a mime type

Comment 7

[Doug Turner (:dougt)]

http://hg.mozilla.org/mobile-browser/rev/b12c56ddf35f

Comment 8

[Alon Zakai (:azakai)]

http://hg.mozilla.org/mozilla-central/rev/128423281c99

Comment 9

[Doug Turner (:dougt)]

Attachment: followup to preserve mime

Comment 10

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/e5a6c1fb7e36

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED On build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b12pre) Gecko/20110210 Firefox/4.0b12pre Fennec/4.0b5pre

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

litmus test case created : 15223