630376 - add an overwrite option to generate_reset_code

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Tarek Ziadé (:tarek)]

if overwrite is False, returns an existing code if any.
if overwrite is True or no code exists, creates and returns a new code

also, rename generate_reset_code to get_reset_code in the process

Comment 1

[Toby Elliott [:telliott]]

I believe that "no code exists" should default to false. i.e. semantically, you need to tell the server to overwrite.

Comment 2

[Tarek Ziadé (:tarek)]

Attachment: add the ovewrite option

Added the overwrite option. also externalized the reset code managment to its own module so all backends can share it. the sql backend just overrides the minimal set of methods to store the reset code in the users tables instead of a dedicated table.

Will do the renaming later

Comment 3

[Tarek Ziadé (:tarek)]

Attachment: add the overwrite option

Forgot to include a test file in the patch

Comment 4

[Toby Elliott [:telliott]]

Comment on attachment 508758 [details] [diff] [review]
add the overwrite option

Looks good. I like having the reset stuff in its own space.

As an aside, since you touch on it here, we should talk about using an API to the node assignment module for node assignments, which would let us abstract all node code out of the user api (hopefully to eventually include the node api call). That's beyond the scope of this bug.

Comment 5

[Tarek Ziadé (:tarek)]

yes agreed, we should have all node assignment related stuff on its own. 

I added bug 631166

Comment 6

[Tarek Ziadé (:tarek)]

Done in http://hg.mozilla.org/services/server-core/rev/0eb30869907c