630444 - Trim LSP annotations

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Trim lsp annotation

The LSP annotation code is taking up a large chunk of the AppNotes space, which I'd like to use for other purposes. This should trim it down a bit.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

How about we just remove it from the appnotes entirely?  It gets cut off before anything interesting anyways :-/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #1)
> How about we just remove it from the appnotes entirely?  It gets cut off before
> anything interesting anyways :-/

That works for me too. Do you want to take it out then?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Sure.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Ted, want to rubberstamp this?

Comment 5

[Josh Matthews [:jdm]]

Well, it _is_ a very easy way to notice that a non-English version of Windows is being used.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

If that information is particularly useful we could expose it in a much less voluminous manner.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Why not remove the note variable as well?

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah, I'll kill that when I land this.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

I landed the reviewed version:
http://hg.mozilla.org/mozilla-central/rev/c698ef73edae

You can fix the dead code in a follow up.

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/347c9f93d23b

And the dead code is gone.