Closed
Bug 630575
Opened 13 years ago
Closed 13 years ago
Properly distinguish soft and hard blocked items in the update pings
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: mossop, Assigned: mossop)
Details
(Whiteboard: [has patch])
Attachments
(2 files)
7.42 KB,
patch
|
Unfocused
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
8.17 KB,
patch
|
robert.strong.bugs
:
review+
dveditz
:
approval1.9.2.17+
dveditz
:
approval1.9.1.19+
|
Details | Diff | Splinter Review |
Currently in Firefox 3.5 and 3.6 we only include the "blocklisted" state if an item is hardblocked. In Firefox 4.0 we include the "blocklisted" state if an item is soft or hard blocked. This causes confusing data and for the branches makes it impossible to verify that blocklist changes are having any effect. We should split it and send "blocklisted" for hard blocks only and "softblocked" for soft blocked items.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → dtownsend
Assignee | ||
Updated•13 years ago
|
Whiteboard: [has patch][waiting on try]
Assignee | ||
Comment 1•13 years ago
|
||
Just for Firefox 4 for now this makes the changes. Turns out there were no tests for this so I added those. I think it's important to take this and bring us back into parity with 3.6 for stats.
Attachment #511242 -
Flags: review?(bmcbride)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [has patch][waiting on try] → [has patch][needs review Unfocused]
Comment 2•13 years ago
|
||
Comment on attachment 511242 [details] [diff] [review] patch rev 1 Makes sense.
Attachment #511242 -
Flags: review?(bmcbride)
Attachment #511242 -
Flags: review+
Attachment #511242 -
Flags: approval2.0?
Assignee | ||
Comment 3•13 years ago
|
||
For drivers, this is really safe code that fixes a regression from 3.6 that generates us confusing stats when we try to evaluate the pickup rate of the blocklist.
Updated•13 years ago
|
Attachment #511242 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 4•13 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/53d06f07a4d2
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Comment 5•13 years ago
|
||
Dave, what's the best way to verify this fix at least for the softblocked items? In which query will the softblocked items be contained in?
Whiteboard: [has patch][needs review Unfocused] → [has patch]
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to comment #5) > Dave, what's the best way to verify this fix at least for the softblocked > items? In which query will the softblocked items be contained in? It shows up in the update ping to AMO or the %ITEM_STATUS% part of a custom updateURL
Assignee | ||
Comment 7•13 years ago
|
||
This adds the softblocked status to the 1.9.2 branch and adds the same tests.
Attachment #517484 -
Flags: review?(robert.bugzilla)
Updated•13 years ago
|
Attachment #517484 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Comment 8•13 years ago
|
||
Comment on attachment 517484 [details] [diff] [review] branch patch I'd like approval to land this on the branches to ensure that we get good feedback from changes to the blocklist. It is a pretty low risk patch and adds more tests than we had previously for this status reporting.
Attachment #517484 -
Flags: approval1.9.2.16?
Attachment #517484 -
Flags: approval1.9.1.18?
Comment 9•13 years ago
|
||
(In reply to comment #3) > For drivers, this is really safe code that fixes a regression from 3.6 that If it's a regression from 3.6 why do we need this patch in 3.6? Or if you meant a regression introduced _in_ 3.6 it's still not clear why you want this patch in 3.5.
Assignee | ||
Comment 10•13 years ago
|
||
(In reply to comment #9) > (In reply to comment #3) > > For drivers, this is really safe code that fixes a regression from 3.6 that > > If it's a regression from 3.6 why do we need this patch in 3.6? Or if you meant > a regression introduced _in_ 3.6 it's still not clear why you want this patch > in 3.5. Neither, that comment was for the 2.0 drivers where we changed the behaviour. Firefox 3.6 and 3.5 tell AMO when they know an add-on that a user has installed is hard blocked but not when it is soft blocked (which 4.0 does do now). We have been using the stats from these pings in the past to verify the rollout of the blocklist updates and without the soft blocked information we can't verify that kind of block is rolling out as we expect.
Comment 11•13 years ago
|
||
Comment on attachment 517484 [details] [diff] [review] branch patch Approved for 1.9.2.16 and 1.9.1.18, a=dveditz for release-drivers
Attachment #517484 -
Flags: approval1.9.2.16?
Attachment #517484 -
Flags: approval1.9.2.16+
Attachment #517484 -
Flags: approval1.9.1.18?
Attachment #517484 -
Flags: approval1.9.1.18+
Assignee | ||
Comment 12•13 years ago
|
||
Landed: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/fabeec97235e http://hg.mozilla.org/releases/mozilla-1.9.1/rev/72a72241e47c
status1.9.1:
--- → .19-fixed
status1.9.2:
--- → .17-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•