Closed
Bug 630876
Opened 13 years ago
Closed 13 years ago
updateKey and updateURL in install.rdf need to be validation errors
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.12.9
People
(Reporter: jorgev, Assigned: basta)
References
()
Details
(Whiteboard: [ReviewTeam])
Attachments
(2 files)
post-fix screenshot
This is one of the few cases where we require the validator to show an error and don't allow the upload to continue. Please make both of these flags throw errors.
|
Assignee | |
Comment 1•13 years ago
|
||
Can do; should we also be banning the use of updateLink?
|
Reporter | |
Comment 2•13 years ago
|
||
Never heard of it. Where did you see it?
|
||
Comment 3•13 years ago
|
||
I think updateLink would only appear in update.rdf, not install.rdf
|
|
Assignee | |
Comment 4•13 years ago
|
||
Even better. Done: https://github.com/mattbasta/amo-validator/commit/b1b729c931032c953c493badb6e9769582330281
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 5•13 years ago
|
||
validation error when install.rdf includes UpdateURL: https://addons.allizom.org/en-US/developers/upload/c6b6ead4f74446cda7bcb8de0ebe3d46 validation error when install.rdf includes Updatekey: https://addons-next.allizom.org/en-US/developers/upload/3333f949bf5941c6891e6a55bd898652
|
|
||
Comment 6•13 years ago
|
||
|
|
||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Comment 7•12 years ago
|
||
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•