Closed
Bug 631006
Opened 13 years ago
Closed 13 years ago
make-package (make-sourcestamp-file) broken when using MOZ_PKG_PRETTYNAMES=1
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This affected beta 11. With MOZ_PKG_PRETTYNAMES=1, PKG_PATH is non-empty, which means that make-sourcestamp-file attempts to write to a file in a non-existent directory: /bin/sh: ../../dist/win32/en-US//firefox-4.0b11.txt: No such file or directory We need to create that directory before make-sourcestamp-file tries to use it (via MOZ_SOURCESTAMP_FILE).
|
Assignee | |
Comment 1•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0d93633ce739 is what caused this.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•13 years ago
|
||
For beta 11, we may want to just back out bug 549958's patch on the relbranch.
|
||
Updated•13 years ago
|
Attachment #509216 -
Flags: review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
We did end up just backing bug 549958 out on the relbranch for b11. Callek landed the fix on the trunk shortly after that: http://hg.mozilla.org/mozilla-central/rev/a6efb7807896
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•