Closed
Bug 631364
Opened 13 years ago
Closed 13 years ago
Add link to orange factor from bugs in tbpl comments for starred oranges
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
Attachments
(1 file)
3.14 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
For bug numbers appearing in comments for starred oranges, we'd like to add a link to the corresponding bug info in the OrangeFactor website, e.g., http://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=626956&startday=2011-01-06&endday=2011-02-03.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #509582 -
Flags: review?
Assignee | ||
Updated•13 years ago
|
Attachment #509582 -
Flags: review? → review?(mstange)
Comment 2•13 years ago
|
||
Comment on attachment 509582 [details] [diff] [review] patch >+ function ISODateString(d) { >+ function pad(n){return n<10 ? '0'+n : n}; >+ return d.getUTCFullYear()+'-' >+ + pad(d.getUTCMonth()+1)+'-' >+ + pad(d.getUTCDate()); >+ }; Just a flyby comment: Please add more spaces around operators, also a semicolon after the return statement.
Comment 3•13 years ago
|
||
Comment on attachment 509582 [details] [diff] [review] patch Looks good, just some style nits: >diff --git a/js/UserInterface.js b/js/UserInterface.js >+ _linkBugs: function UserInterface__linkBugs(text, add_orangefactor_link) { Call the parameter addOrangefactorLink. >+ function ISODateString(d) { >+ function pad(n){return n<10 ? '0'+n : n}; >+ return d.getUTCFullYear()+'-' >+ + pad(d.getUTCMonth()+1)+'-' >+ + pad(d.getUTCDate()); >+ }; Make this UserInterface._ISODateString and use UserInterface._pad instead of defining another pad function. Also please address Arpad's request about spaces around operators. >+ var earlier = new Date(today.getTime() - (1000 * 60 * 60 * 24 * 60)); Maybe call this sixtyDaysAgo so that I don't have to parse the calculation every time I read this :) >+ buglink += ' [<a class="testfailed" href="http://brasstacks.mozilla.com/orangefactor/?display=Bug&endday=' + I'd prefer it if the link looked like a link, so please don't use class="testfailed" here.
Attachment #509582 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 4•13 years ago
|
||
All review comments addressed; pushed as http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/df52b5c4e543
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Webtools → Tree Management
Updated•9 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•