631546 - Run unit tests and talos for mozilla-2.0 releases

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

Not sure why, because the tests are no longer valid on these machines aiui.

Comment 1

[Armen [:armenzg]]

I will look into it before the next beta.

Comment 2

[Chris Cooper [:coop] (he/him)]

Dupe of bug 630940?

Comment 3

[Armen [:armenzg]]

Attachment: [not tested] remove unit test on the builders for ff4 releases

No, this is not a DUP.

This is the patch needed but I would need to test it to make sure that we would still be creating the packaged tests and do the sendchanges.

Comment 4

[Armen [:armenzg]]

It is not necessary to fix it for the next beta but needs to be fixed.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 511505 [details] [diff] [review]
[not tested] remove unit test on the builders for ff4 releases

This patch was applied as part of bug 630940.

We still need to get unittest packages uploaded and sendchanges going in this bug.

Comment 6

[Armen [:armenzg]]

Attachment: [mozilla-tests/config.py] add release builders for 2.0 plus u

What do you think?

There is much more we can move to DEFAULTS and RELEASE_DEFAULTS but I would like to keep it simple for this patch.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 525080 [details] [diff] [review]
[mozilla-tests/config.py] add release builders for 2.0 plus u

For right now, I would rather see these release-specific values added to mozilla-2.0 instead since bug 633054 is going to look at a whole config merge

Comment 8

[Armen [:armenzg]]

Attachment: [mozilla-tests/config.py] add release builders for mozilla-2.0

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 525147 [details] [diff] [review]
[mozilla-tests/config.py] add release builders for mozilla-2.0

good stuff, thanks armen

Comment 10

[Armen [:armenzg]]

Comment on attachment 525147 [details] [diff] [review]
[mozilla-tests/config.py] add release builders for mozilla-2.0

Checked in on "default" with:
http://hg.mozilla.org/build/buildbot-configs/rev/b2eddd6ca339

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

That gets you Talos. I think we need to fix 
  releaseConfig['unittestPlatforms']   = ()
in buildbot-configs/mozilla/release-firefox-mozilla-2.0.py to get unit tests too.

Comment 13

[Armen [:armenzg]]

(In reply to comment #12)
> That gets you Talos. I think we need to fix 
>   releaseConfig['unittestPlatforms']   = ()
> in buildbot-configs/mozilla/release-firefox-mozilla-2.0.py to get unit tests
> too.

That switch is if we want unit tests on the builders which we don't want.

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Are you sure ? That's not what it looks like from
 http://mxr.mozilla.org/build/source/buildbotcustom/process/release.py#407
 http://mxr.mozilla.org/build/source/buildbotcustom/process/release.py#634
 http://mxr.mozilla.org/build/source/buildbotcustom/process/release.py#750
and generateTestBuilder() generating builders of class UnittestPackagedBuildFactory.

Comment 15

[Armen [:armenzg]]

That is for unit tests on the builders. Test masters don't use process/release.py.
The only thing needed on the builders is to enable_packages which enables the sendchanges for unit tests.
Test masters only use http://mxr.mozilla.org/build/source/buildbotcustom/misc.py#2607

Comment 16

[Armen [:armenzg]]

This got merged to production with:
http://hg.mozilla.org/build/buildbot-configs/rev/70818a09be7e