Closed
Bug 631662
Opened 13 years ago
Closed 13 years ago
We are painting thumbnails while in the background
Categories
(Firefox Graveyard :: Panorama, defect, P2)
Firefox Graveyard
Panorama
Tracking
(blocking2.0 final+)
RESOLVED
FIXED
Firefox 4.0b12
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: iangilman, Assigned: ttaubert)
References
Details
(Whiteboard: [hardblocker][has patch][qa-])
Attachments
(1 file, 1 obsolete file)
|
3.57 KB,
patch
|
Details | Diff | Splinter Review |
We receive the events when the user is not in the Panorama UI, but we're supposed to just queue them up for later handling; it's not till you reenter the Panorama UI that thumbnails are supposed to be actually updated. bug 625561 has evidence that we're actually updating thumbnails while not in the Panorama UI. Looking at the code, we don't have an explicit check for whether you're in TabView; we just rely on paintingPaused, which should be set to true when TabView is hidden, but maybe it's not? This needs to be fixed due to its perf impact on regular pages.
|
||
Updated•13 years ago
|
blocking2.0: --- → ?
|
Assignee | |
Comment 1•13 years ago
|
||
Confirming. We're even painting twice when switching tabs.
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Version: unspecified → Trunk
|
|
Assignee | |
Updated•13 years ago
|
Summary: Are we painting thumbnails while in the background? → We are painting thumbnails while in the background
|
||
Comment 2•13 years ago
|
||
Hardblocker - panorama should not impact perf for people who never use it. Can we get a patch up here right away?
blocking2.0: ? → final+
Whiteboard: [hardblocker]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Yep, it's almost done.
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to comment #2) > Hardblocker - panorama should not impact perf for people who never use it. Can > we get a patch up here right away? Oh and to be clear: this is not affecting users that never opened panorama.
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #509933 -
Flags: review?(ian)
|
Reporter | |
Comment 6•13 years ago
|
||
Comment on attachment 509933 [details] [diff] [review] patch v1 Beautiful
Attachment #509933 -
Flags: review?(ian) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
(In reply to comment #5) > Created attachment 509933 [details] [diff] [review] > patch v1 Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=0cc58f595787
|
|
Assignee | |
Comment 8•13 years ago
|
||
Attachment #509933 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Updated•13 years ago
|
Whiteboard: [hardblocker] → [hardblocker][has patch]
|
||
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/378f8ebcc920
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
|
||
Updated•13 years ago
|
Whiteboard: [hardblocker][has patch] → [hardblocker][has patch][qa-]
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•