Closed Bug 631868 Opened 13 years ago Closed 13 years ago

Tab drift in TabItem_setBounds code

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b12

People

(Reporter: mitcho, Assigned: mitcho)

References

Details

(Whiteboard: [cleanup][qa-])

Attachments

(1 file, 1 obsolete file)

Patch for checkin
6.39 KB, patch
Details | Diff | Splinter Review 
Tabbing in the TabItem_setBounds code on trunk is wacked out... a section of it just got overly indented. Fix it.
Attached patch Trivial patch (obsolete) — — Splinter Review 
Assignee: nobody → mitcho
Status: NEW → ASSIGNED

        Attachment #510152 -
        Flags: review?(ian)

    
    

    
  
Mitcho, thanks for catching this! 

Presumably the "ignore white space changes" version of the patch for bug 624931 landed, causing this.

        Attachment #510152 -
        Flags: review?(ian) → review+

    
    

    
  
(In reply to comment #0)
> Tabbing in the TabItem_setBounds code on trunk is wacked out... a section of it
> just got overly indented. Fix it.

Possibly the wrong version of the patch got checked in. Anyway, thanks for the patch :)

    
    

    
  
Comment on attachment 510152 [details] [diff] [review]
Trivial patch

Trivial code cleanup bug. No risk! Approval please.

        Attachment #510152 -
        Flags: approval2.0?

        Attachment #510152 -
        Flags: approval2.0? → approval2.0+

    
    

    
  


  

        Attachment #510152 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/18b965056289
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: