631936 - Flaw in GroupItem_childHit logic: we are calling collapse on groups every time we zoom in on a child tab, even if the group is not stacked!

Status: RESOLVED INVALID

(Firefox Graveyard :: Panorama, defect)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

In GroupItem_childHit:

>    if (!this._isStacked || this.expanded) {
>      return {
>        shouldZoom: true,
>        callback: function() {
>          self.collapse();
>        }
>      };
>    }

This if condition is wrong: if, for example, the group isn't even stacked, we will send back this callback so that the group is collapsed after we zoom in on a child tab.

Verified that this indeed is what currently happens. Luckily collapse doesn't do anything if the group is not expanded.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Trivial patch

Not sure that there's a good way to write a test for this without modifying the collapse method in the global scope from within the test... seems a bit sketchy, even if we do it in a new window just for this test.

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

Okay "in the global scope" above doesn't totally make sense, but hopefully you know what I mean. :)

Comment 3

[Ian Gilman [:iangilman]]

As discussed in bug 631934, let's just make this change there.